[Backport release-1.27] Bump golangci-lint to v1.57.1 #4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]> (cherry picked from commit f704ee2)
The linting workflows in CI are always close at the timeout. Some of them actually fail because they take too long and need to be restarted. Increase the timeout from 8 to 15 minutes. The project (and probably the linter, too) grew over time and hence linting might take longer. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 47b4305)
Adapt to updated linters: * Update configuration * Silence some opinionated new warnings https://github.com/golangci/golangci-lint/releases/tag/v1.52.0 https://github.com/golangci/golangci-lint/releases/tag/v1.52.1 https://github.com/golangci/golangci-lint/releases/tag/v1.52.2 https://github.com/golangci/golangci-lint/releases/tag/v1.53.0 https://github.com/golangci/golangci-lint/releases/tag/v1.53.1 https://github.com/golangci/golangci-lint/releases/tag/v1.53.2 https://github.com/golangci/golangci-lint/releases/tag/v1.53.3 https://github.com/golangci/golangci-lint/releases/tag/v1.54.0 https://github.com/golangci/golangci-lint/releases/tag/v1.54.1 https://github.com/golangci/golangci-lint/releases/tag/v1.54.2 https://github.com/golangci/golangci-lint/releases/tag/v1.55.0 https://github.com/golangci/golangci-lint/releases/tag/v1.55.1 https://github.com/golangci/golangci-lint/releases/tag/v1.55.2 Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 0873cfe) (cherry picked from commit d7938de)
https://github.com/golangci/golangci-lint/releases/tag/v1.56.0 https://github.com/golangci/golangci-lint/releases/tag/v1.56.1 https://github.com/golangci/golangci-lint/releases/tag/v1.56.2 Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 90acacc) (cherry picked from commit 5d478a4) (cherry picked from commit 088d191)
https://golangci-lint.run/product/changelog/#v1571 Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 49b196b) (cherry picked from commit 89a0bae) (cherry picked from commit 1444df0)
The skip* settings have been moved from the run section to the issues section and renamed to exclude*. The golint linter has long been deprecated and removed. Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit 43b1652) (cherry picked from commit 01054cf) (cherry picked from commit 93feb47)
jnummelin
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to
release-1.27:See: