-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reclaim GitHub Runner disk space #3572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub runners provide 14GB of guaranteed available disk space, which is typically sufficient for running k0s's integration tests. However, when free space drops below 15%, Kubernetes initiates pod eviction, leaving only 5GB left on an 84GB disk until it kicks in. In response, streamline disk space usage and remove non-essential data. That's easier than globally overriding Kubernetes eviction defaults for all integration tests. Signed-off-by: Tom Wieczorek <[email protected]>
…est" This reverts commit 6e16eb8. Signed-off-by: Tom Wieczorek <[email protected]>
jnummelin
reviewed
Oct 11, 2023
set +eux | ||
|
||
if [ -z "$GITHUB_RUN_ID" ]; then | ||
echo "Cowardly refusing to destroy a machine that doesn't look like a GitHub runner." >&2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂 I really like this comment
jnummelin
approved these changes
Oct 11, 2023
twz123
added
the
backport/release-1.28
PR that needs to be backported/cherrypicked to release-1.28 branch
label
Oct 11, 2023
Successfully created backport PR for |
This was referenced Oct 23, 2023
ncopa
added a commit
to ncopa/k0s
that referenced
this pull request
Aug 1, 2024
Verify that we have at least 15% relative disk space free to keep kubelet happy. ref: k0sproject#3572 ref: https://kubernetes.io/docs/concepts/scheduling-eviction/node-pressure-eviction/#hard-eviction-thresholds Fixes: k0sproject#3644 Signed-off-by: Natanael Copa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ci
area/smoke-tests
backport/release-1.28
PR that needs to be backported/cherrypicked to release-1.28 branch
bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub runners provide 14GB of guaranteed available disk space, which is typically sufficient for running k0s's integration tests. However, when free space drops below 15%, Kubernetes initiates pod eviction, leaving only 5GB left on an 84GB disk until it kicks in. In response, streamline disk space usage and remove non-essential data. That's easier than globally overriding Kubernetes eviction defaults for all integration tests.
Also revert #3470 which was another workaround that solved the problem for a single integration test.
Type of change
How Has This Been Tested?
Checklist: