Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reclaim GitHub Runner disk space #3572

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Oct 11, 2023

Description

GitHub runners provide 14GB of guaranteed available disk space, which is typically sufficient for running k0s's integration tests. However, when free space drops below 15%, Kubernetes initiates pod eviction, leaving only 5GB left on an 84GB disk until it kicks in. In response, streamline disk space usage and remove non-essential data. That's easier than globally overriding Kubernetes eviction defaults for all integration tests.

Also revert #3470 which was another workaround that solved the problem for a single integration test.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

GitHub runners provide 14GB of guaranteed available disk space, which is
typically sufficient for running k0s's integration tests. However, when
free space drops below 15%, Kubernetes initiates pod eviction, leaving
only 5GB left on an 84GB disk until it kicks in. In response, streamline
disk space usage and remove non-essential data. That's easier than
globally overriding Kubernetes eviction defaults for all integration
tests.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added bug Something isn't working area/ci area/smoke-tests labels Oct 11, 2023
set +eux

if [ -z "$GITHUB_RUN_ID" ]; then
echo "Cowardly refusing to destroy a machine that doesn't look like a GitHub runner." >&2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 I really like this comment

@twz123 twz123 added the backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch label Oct 11, 2023
@twz123 twz123 marked this pull request as ready for review October 11, 2023 13:53
@twz123 twz123 requested a review from a team as a code owner October 11, 2023 13:53
@twz123 twz123 requested review from ncopa and makhov October 11, 2023 13:53
@twz123 twz123 merged commit 0d1bad0 into k0sproject:main Oct 11, 2023
@twz123 twz123 deleted the reclaim-gh-runner-disk-space branch October 11, 2023 13:54
@k0s-bot
Copy link

k0s-bot commented Oct 11, 2023

Successfully created backport PR for release-1.28:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/smoke-tests backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants