Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Debugging calico test disk issues #3468

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] Debugging calico test disk issues #3468

wants to merge 1 commit into from

Conversation

jnummelin
Copy link
Member

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jnummelin jnummelin requested a review from a team as a code owner September 8, 2023 12:12
@twz123 twz123 marked this pull request as draft September 8, 2023 12:12
@jnummelin jnummelin force-pushed the debug/calico-conformance branch 3 times, most recently from e1045cb to b3f8513 Compare September 8, 2023 12:51
@jnummelin jnummelin force-pushed the debug/calico-conformance branch from b3f8513 to e9a4915 Compare September 8, 2023 13:04
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added Stale and removed Stale labels Oct 8, 2023
@twz123
Copy link
Member

twz123 commented Oct 26, 2023

I guess this is no longer required, since we solved the CI issues via #3572.

@twz123 twz123 closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twz123 twz123 Awaiting requested review from twz123 twz123 is a code owner automatically assigned from k0sproject/k0s-maintainers

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas juanluisvaladas is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnummelin @twz123