Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower disk space eviction limits for network conformance inttest #3470

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Sep 11, 2023

Description

Recently, the network conformance inttest has been failing regularly. This is because the sonobuoy pods are being evicted when the available disk space on the GitHub runners falls below the default eviction limits. Mitigate this by lowering the eviction limits.

This is a duct-tape solution. It's unclear whether the reduced amount of free disk space on the GitHub runners is due to changes made by GitHub or to changes in k0s.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Recently, the network conformance inttest has been failing regularly.
This is because the sonobuoy pods are being evicted when the available
disk space on the GitHub runners falls below the default eviction
limits. Mitigate this by lowering the eviction limits.

This is duct-tape solution. It's unclear whether the reduced amount of
free disk space on the GitHub runners is due to changes made by GitHub
or to changes in k0s.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added bug Something isn't working area/ci labels Sep 11, 2023
@twz123 twz123 marked this pull request as ready for review September 11, 2023 11:58
@twz123 twz123 requested a review from a team as a code owner September 11, 2023 11:58
@twz123 twz123 merged commit c18915e into k0sproject:main Sep 11, 2023
71 checks passed
@twz123 twz123 deleted the netconf-inttest-no-eviction branch September 11, 2023 12:34
@twz123 twz123 restored the netconf-inttest-no-eviction branch September 11, 2023 12:35
@twz123 twz123 deleted the netconf-inttest-no-eviction branch September 11, 2023 12:35
@twz123 twz123 mentioned this pull request Oct 11, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants