Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pie-icons-webc): DSW-1539 icon display and size override variables #1127

Merged
merged 2 commits into from
Jan 2, 2024
Merged

fix(pie-icons-webc): DSW-1539 icon display and size override variables #1127

merged 2 commits into from
Jan 2, 2024

Conversation

dandel10n
Copy link
Contributor

@dandel10n dandel10n commented Dec 21, 2023 •
edited
Loading

Describe your changes (can list changeset entries if preferable)

"@justeattakeaway/pie-icons-webc": patch

[Changed] - --btn-icon-size and --btn-icon-display to --icon-display-override and --icon-size-override variable for display, width and height icon styles for :host svg

"@justeattakeaway/pie-button": patch

[Changed] - --btn-icon-display and --btn-icon-size to --icon-display-override and --icon-size-override variables

"@justeattakeaway/pie-icon-button": patch

[Changed] - --btn-icon-display and --btn-icon-size to --icon-display-override and --icon-size-override variables

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • If it is a PIE Docs change, I have reviewed the Docs site preview
  • If it is a component change, I have reviewed the Storybook preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)

Reviewer 1

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

@dandel10n dandel10n requested review from a team as code owners December 21, 2023 12:13
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: a03c4de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@justeattakeaway/pie-icon-button Patch
@justeattakeaway/pie-icons-webc Patch
@justeattakeaway/pie-button Patch
wc-vanilla Patch
pie-storybook Patch
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-modal Patch
@justeattakeaway/pie-switch Patch
wc-angular12 Patch
wc-next10 Patch
wc-next13 Patch
wc-nuxt2 Patch
wc-nuxt3 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1127 December 21, 2023 12:22 Inactive
@jamieomaguire
Copy link
Contributor

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

🫰✨ Thanks @jamieomaguire! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]

This was referenced Dec 21, 2023
Merged
Merged
FayeCarter
FayeCarter previously approved these changes Dec 21, 2023
View reviewed changes
ashleynolan
ashleynolan requested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@ashleynolan ashleynolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to update the --btn-icon-size references in iconButton.scss

@dandel10n
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1127 December 21, 2023 15:20 Inactive
@pie-design-system-bot
Copy link
Contributor

🫰✨ Thanks @dandel10n! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]

@dandel10n dandel10n marked this pull request as draft December 21, 2023 16:58
@dandel10n dandel10n changed the title fix(pie-icons-webc): DSW-1539 icon display and size override variables fix(pie-icons-webc): WIP DO NOT MERGE DSW-1539 icon display and size override variables Dec 21, 2023
github-actions[bot]

This comment was marked as outdated.

Sign in to view

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1127 December 21, 2023 17:07 Inactive
@dandel10n dandel10n changed the title fix(pie-icons-webc): WIP DO NOT MERGE DSW-1539 icon display and size override variables fix(pie-icons-webc): DSW-1539 icon display and size override variables Dec 22, 2023
@github-actions github-actions bot dismissed their stale review December 22, 2023 10:42

[Lint PR Title] ✅ All good!

@dandel10n dandel10n force-pushed the dsw-1539-icon-styles branch 2 times, most recently from 12d4195 to 4969ff8 Compare December 22, 2023 10:49
@dandel10n
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

The build failed, please see the logs or take a look at the Workflow Tooling wiki page to make sure your PR meets the requirements.

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1127 December 22, 2023 10:58 Inactive
@dandel10n
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

The build failed, please see the logs or take a look at the Workflow Tooling wiki page to make sure your PR meets the requirements.

@dandel10n dandel10n marked this pull request as ready for review December 22, 2023 11:24
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1127 December 22, 2023 11:30 Inactive
@dandel10n
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

🫰✨ Thanks @dandel10n! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]
yarn add @justeattakeaway/[email protected]

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1127 December 22, 2023 16:03 Inactive
@dandel10n dandel10n merged commit e27452b into main Jan 2, 2024
35 checks passed
@dandel10n dandel10n deleted the dsw-1539-icon-styles branch January 2, 2024 10:50
This was referenced Jan 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleynolan ashleynolan ashleynolan approved these changes

@kevinrodrigues kevinrodrigues kevinrodrigues approved these changes

@jamieomaguire jamieomaguire jamieomaguire approved these changes

@FayeCarter FayeCarter FayeCarter left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
components pie-button pie-icon-button tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dandel10n @jamieomaguire @pie-design-system-bot @ashleynolan @kevinrodrigues @FayeCarter