Skip to content

Commit

Permalink
fix(pie-icon-button): DSW-1539 icon display and size override variables
Browse files Browse the repository at this point in the history
  • Loading branch information
dandel10n committed Dec 21, 2023
1 parent 95ffde4 commit 4d560ae
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
5 changes: 5 additions & 0 deletions .changeset/chilled-snails-cry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@justeattakeaway/pie-icon-button": patch
---

[Changed] - `--btn-icon-display` and `--btn-icon-size` to `--icon-display-override` and `--icon-size-override` variables
10 changes: 5 additions & 5 deletions packages/components/pie-icon-button/src/iconButton.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
--btn-border-radius: var(--dt-radius-rounded-e);
--btn-bg-color: var(--dt-color-interactive-brand);
--btn-icon-fill: var(--dt-color-content-interactive-primary);
--btn-icon-display: block;
--icon-display-override: block;

block-size: var(--btn-dimension, var(--btn-dimension-default));
inline-size: var(--btn-dimension, var(--btn-dimension-default));
Expand All @@ -37,8 +37,8 @@
}

svg {
height: var(--btn-icon-size, var(--btn-icon-size-default));
width: var(--btn-icon-size, var(--btn-icon-size-default));
height: var(--icon-size-override, var(--btn-icon-size-default));
width: var(--icon-size-override, var(--btn-icon-size-default));
}

&[variant='primary'] {
Expand Down Expand Up @@ -109,7 +109,7 @@

&[size='xsmall'] {
--btn-dimension: 32px;
--btn-icon-size: 20px;
--icon-size-override: 20px;
}

&[size='small'] {
Expand All @@ -122,7 +122,7 @@

&[size='large'] {
--btn-dimension: 56px;
--btn-icon-size: 28px;
--icon-size-override: 28px;
}
}

0 comments on commit 4d560ae

Please sign in to comment.