-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding option initialDumps to Postgres #67
Merged
shivaraj-bh
merged 6 commits into
juspay:main
from
rsrohitsingh682:add-initial-dumps-option
Dec 26, 2023
Merged
Adding option initialDumps to Postgres #67
shivaraj-bh
merged 6 commits into
juspay:main
from
rsrohitsingh682:add-initial-dumps-option
Dec 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run during database initialization.
rsrohitsingh682
changed the title
Added an option initialDumps to be used to add lists of sql dumps to …
Adding option initialDumps to Postgres
Dec 22, 2023
This will only work after #66 |
@rsrohitsingh682 You will have to rebase with main, some structural changes were done to the postgres service in #66 |
shivaraj-bh
reviewed
Dec 26, 2023
shivaraj-bh
requested changes
Dec 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s include a test for initialDatabases
Co-authored-by: Shivaraj B H <[email protected]>
shivaraj-bh
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #64
Added an option initialDumps which can be used to load lists of SQL dumps during the database initialization.