Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Postgres]: Use schemas in-place of initialDumps #73

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Conversation

shivaraj-bh
Copy link
Member

@shivaraj-bh shivaraj-bh commented Jan 13, 2024

Problem

initialDumps is always created under postgres database, which is not a desirable default behaviour when your dumps are intended for different database, like atlas_dev in nammayatri.

Solution

We already have schema module option to load a schema into a given database name. The schema module option already supports loading from either a file or all the .sql files in a folder.

The sql dumps in some cases can be scattered across folders, and hence we can rename schema to schemas and allow it.

Tagging @rsrohitsingh682 here as he had worked on initialDumps

nix/postgres/postgres_test.nix Outdated Show resolved Hide resolved
nix/postgres/setup-script.nix Show resolved Hide resolved
@shivaraj-bh shivaraj-bh merged commit 62e1371 into main Jan 13, 2024
2 checks passed
@shivaraj-bh shivaraj-bh deleted the postgres-schemas branch January 13, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants