-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(email): Add mailhog by default in docker-compose for local smtp server #6869
Open
jagan-jaya
wants to merge
11
commits into
main
Choose a base branch
from
add-mailhog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
839cd97
chore(email): add mailhog support to test emails in local
jagan-jaya dcbee3d
chore(email): rename default host
jagan-jaya 642f158
chore(email): update user base_url
jagan-jaya aab2ca3
Merge branch 'main' of https://github.com/juspay/hyperswitch into add…
jagan-jaya 0c06af3
Merge branch 'main' into add-mailhog
jagan-jaya 492daa8
chore: merge main changes
prajwalnl0 d7f47b9
chore(docker): add forex_enabled property in docker compose
prajwalnl0 40fb510
configs: update latest docker compose configs
jagan-jaya 8caca5b
configs: disable force cookies
jagan-jaya 1065533
Merge branch 'main' of https://github.com/juspay/hyperswitch into add…
jagan-jaya 64e8673
chore: update router latest image
jagan-jaya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,7 @@ master_enc_key = "73ad7bbbbc640c845a150f67d058b279849370cd2c1f3c67c4dd6c869213e1 | |
password_validity_in_days = 90 | ||
two_factor_auth_expiry_in_secs = 300 | ||
totp_issuer_name = "Hyperswitch" | ||
base_url = "http://localhost:8080" | ||
base_url = "http://localhost:9000" | ||
force_two_factor_auth = false | ||
force_cookies = true | ||
|
||
|
@@ -568,6 +568,7 @@ authentication_analytics_topic = "hyperswitch-authentication-events" | |
|
||
[analytics] | ||
source = "sqlx" | ||
forex_enabled = false # Enable or disable forex conversion for analytics | ||
|
||
[analytics.clickhouse] | ||
username = "default" | ||
|
@@ -685,7 +686,7 @@ connector_list = "cybersource" | |
sender_email = "[email protected]" # Sender email | ||
aws_region = "" # AWS region used by AWS SES | ||
allowed_unverified_days = 1 # Number of days the api calls ( with jwt token ) can be made without verifying the email | ||
active_email_client = "NO_EMAIL_CLIENT" # The currently active email client | ||
active_email_client = "SMTP" # The currently active email client | ||
recon_recipient_email = "[email protected]" # Recipient email for recon request email | ||
prod_intent_recipient_email = "[email protected]" # Recipient email for prod intent email | ||
|
||
|
@@ -697,6 +698,13 @@ sts_role_session_name = "" # An identifier for the assumed role session, used to | |
[theme.storage] | ||
file_storage_backend = "file_system" # Theme storage backend to be used | ||
|
||
# Configuration for smtp, applicable when the active email client is SMTP | ||
[email.smtp] | ||
host = "mailhog" # SMTP host | ||
port = 1025 # SMTP port | ||
timeout = 10 # Timeout for SMTP connection in seconds | ||
connection = "plaintext" #currently plaintext and starttls are supported | ||
|
||
[theme.email_config] | ||
entity_name = "Hyperswitch" # Name of the entity to be showed in emails | ||
entity_logo_url = "https://example.com/logo.svg" # Logo URL of the entity to be used in emails | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
email support is enabled, so nightly image is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we consider nightly images to be unstable, we can't use them in Docker Compose setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use hyperswitch-router:latest? this should be built based on last stable release right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is based on latest stable release.
But does the
latest
image tag work with the Docker Compose setup, considering that it would also have the encryption service related features enabled? Have we tried using it in our Docker Compose setup?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, working as expected in local