Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(email): Add mailhog by default in docker-compose for local smtp server #6869

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jagan-jaya
Copy link
Contributor

@jagan-jaya jagan-jaya commented Dec 18, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add support to run local email server in docker-compose. User can see the email we send even in local setup

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@jagan-jaya jagan-jaya requested review from a team as code owners December 18, 2024 04:38
Copy link

Review changes with  SemanticDiff

@jagan-jaya jagan-jaya changed the title Add mailhog by default in docke-compose for local smtp server Add mailhog by default in docker-compose for local smtp server Dec 18, 2024
@jagan-jaya jagan-jaya self-assigned this Dec 18, 2024
@prajwalnl0 prajwalnl0 changed the title Add mailhog by default in docker-compose for local smtp server feat(email): Add mailhog by default in docker-compose for local smtp server Dec 19, 2024
@prajwalnl0 prajwalnl0 linked an issue Dec 19, 2024 that may be closed by this pull request

### Application services
hyperswitch-server:
image: juspaydotin/hyperswitch-router:standalone
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

email support is enabled, so nightly image is needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we consider nightly images to be unstable, we can't use them in Docker Compose setup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use hyperswitch-router:latest? this should be built based on last stable release right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is based on latest stable release.

But does the latest image tag work with the Docker Compose setup, considering that it would also have the encryption service related features enabled? Have we tried using it in our Docker Compose setup?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, working as expected in local

JeevaRamu0104
JeevaRamu0104 previously approved these changes Jan 8, 2025
ThisIsMani
ThisIsMani previously approved these changes Jan 8, 2025
@jagan-jaya jagan-jaya dismissed stale reviews from ThisIsMani and JeevaRamu0104 via 64e8673 January 10, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(email): Local SMTP server
5 participants