-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(email): Add mailhog by default in docker-compose for local smtp server #6869
base: main
Are you sure you want to change the base?
Conversation
|
||
### Application services | ||
hyperswitch-server: | ||
image: juspaydotin/hyperswitch-router:standalone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
email support is enabled, so nightly image is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we consider nightly images to be unstable, we can't use them in Docker Compose setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use hyperswitch-router:latest? this should be built based on last stable release right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is based on latest stable release.
But does the latest
image tag work with the Docker Compose setup, considering that it would also have the encryption service related features enabled? Have we tried using it in our Docker Compose setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, working as expected in local
64e8673
Type of Change
Description
Add support to run local email server in docker-compose. User can see the email we send even in local setup
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy