Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): add expiry year conversion for adyen mit transactions #6851

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Dec 16, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR fixes MIT payments failing especially during NTID flow.
We previously used to get below error message during MIT Confirm call:

"The provided Expiry Date is not valid.: Expiry year should be a 4 digit number greater than 2000: 30"

closes #6850

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

xecuted below commands:

# cherry picked commits from my cypress branch which is where the existence of this issue came into light
git cherry-pick -n ..cypress-delete-pm

# ran necessary migrations on the latest branch
just migrate

# started the server
cargo r

ran the cypress NTID tests for Adyen:

image

full test (based on #6735) -- no regressions found with adyen:

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@pixincreate pixincreate added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 16, 2024
@pixincreate pixincreate added this to the December 2024 Release milestone Dec 16, 2024
@pixincreate pixincreate self-assigned this Dec 16, 2024
@pixincreate pixincreate requested a review from a team as a code owner December 16, 2024 11:55
Copy link

semanticdiff-com bot commented Dec 16, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector/adyen/transformers.rs  28% smaller

@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit c154a38 Dec 17, 2024
24 of 26 checks passed
@likhinbopanna likhinbopanna deleted the pix-mit-adyen branch December 17, 2024 11:32
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] adyen mit transactions in ntid flow fail due mis matched expiry conversion
4 participants