ci: add tests that make use of locker #6735

pixincreate · 2024-12-04T08:01:51Z

Type of Change

Description

This PR introduces necessary refactoring to add support for locker specific tests. This includes addition of delete payment method (which is restricted to work only on hosted environments and not local given tartarus is unavailable and is complicated to setup things) but not limited to:

fixes:
- fix reports not being generated
- fix multiple credential not picking proper api keys
refactoring:
- move configs that makes use of response custom under getCustomExchange
misc:
- clarify ntid files to make them meaningful
- update dependencies
- update cypress credential to support stripe multiple api keys
feat:
- add multiple credential support for stripe
- add ntid support for stripe with another api key
- add recurring mit payment endpoint to ntid connector agnostic flows

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

delete payment method:

local	hosted

`5xx` is expected since this requires locker to be set up locally which is not optimal	`2xx` is expected since locker is already setup

ntid with mit based on payment token:

cybersource	stripe

adyen	bluesnap	cybersource	stripe

adyen ntid failure has been addressed in #6851. #6735 has been soft cherry-picked and the tests have been run against local			stripe with multiple credential support (ntid)

Checklist

I formatted the code prettier . --write
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2024-12-04T08:01:55Z

Review changes with

Changed Files

File	Status
cypress-tests/cypress/utils/RequestBodyUtils.js	56% smaller
cypress-tests/cypress/e2e/PaymentTest/00003-ConnectorCreate.cy.js	18% smaller
cypress-tests/cypress/support/commands.js	18% smaller
cypress-tests/cypress/e2e/PaymentUtils/Cybersource.js	17% smaller
cypress-tests/cypress/e2e/PaymentUtils/Commons.js	10% smaller
cypress-tests/cypress/e2e/PaymentUtils/Utils.js	8% smaller
cypress-tests/cypress/utils/featureFlags.js	8% smaller
cypress-tests/cypress/e2e/PaymentUtils/Stripe.js	7% smaller
cypress-tests/cypress/e2e/PaymentTest/00024-ConnectorAgnosticNTID.cy.js	2% smaller
cypress-tests/cypress/e2e/PaymentTest/00020-MandatesUsingNTIDProxy.cy.js	0% smaller
cypress-tests/cypress/e2e/PaymentTest/00023-PaymentMethods.cy.js	0% smaller
cypress-tests/cypress/e2e/PaymentUtils/Adyen.js	0% smaller
cypress-tests/cypress/e2e/PaymentUtils/WorldPay.js	0% smaller

likhinbopanna · 2024-12-04T11:07:43Z

Can you handle all the connectors for the connector agnostic change ?

pixincreate · 2024-12-04T11:53:59Z

good catch. by the looks of it (re: stripe), this will require a bit of time and a bit of refactoring in mca create call since we're creating mca independently multiple times in connector agnostic.

pixincreate · 2024-12-05T17:56:01Z

marking this pr as draft since there exist a lot of blockers when working with ntid flows

…tomExchange`

cypress-tests/cypress/e2e/PaymentUtils/Commons.js

jagan-jaya · 2024-12-17T13:48:45Z

cypress-tests/cypress/e2e/PaymentUtils/Stripe.js

+    MITAutoCapture: getCustomExchange({
+      Configs: {
+        CONNECTOR_CREDENTIAL: {
+          specName: ["connectorAgnostic"],


what is the use of this specName: ["connectorAgnostic"] array?
when do you use this specName config, is there a way to make it intuitive and self explanatory?

glad you asked!

we pass specName within Configs when we want to restrict a connector credential to a specific request / exchange.

in this case, connectorAgnostic file (00024) will have connector_2 passed in every MITAutoCapture call that is made. and in mandates, if used, connector_2 will not be passed and hence the default will be sent (connector_1).

edit:

i intentionally made it an array because it allows us to pass multiple files...

likhinbopanna · 2024-12-17T13:54:49Z

cypress-tests/cypress/e2e/PaymentTest/00003-ConnectorCreate.cy.js

          fixtures.businessProfile.bpCreate,
          globalState,
-          "profile" + i
+          { nextConnector: true }


This object makes only 2 creds to work right ?

yes. keeping scalibility in mind, i've made it an object. so, once the need arrives, we can directly make it accept more credentials without much hassle as explained the other day

cypress-tests/cypress/e2e/PaymentTest/00024-ConnectorAgnosticNTID.cy.js

this is allow us to see the error message directly in the screenshot without us manually running the test

…ete-pm * 'main' of github.com:juspay/hyperswitch: chore(version): 2024.12.18.0 fix(payment_methods): card_network and card_scheme should be consistent (#6849) fix(core): Populate off_session based on payments request (#6855)

pixincreate · 2024-12-19T07:44:08Z

~~blocked until an issue with ntid is fixed where stripe is getting affected.~~

edit: fixed with #6899

This reverts commit 098d999.

This reverts commit f19226d.

…ete-pm * 'main' of github.com:juspay/hyperswitch: refactor(dynamic_routing): add col payment_method_type in dynamic_routing_stats (#6853) refactor(customers_v2): include minor fixes for customer v2 flows (#6876) fix: cypress reports generation (#6894) fix(connector): Paypal BankRedirects (Ideal/EPS) (#6864) chore(version): 2024.12.19.1 fix(connector): [UNIFIED_AUTHENTICATION_SERVICE] change url path to `pre_authentication_processing` in pre-auth flow (#6885) refactor(users): move roles schema to global interface (#6862) feat(payment_methods): add support to pass apple pay recurring details to obtain apple pay merchant token (#6770) feat(payments): [Payment links] Add config for changing button text for payment links (#6860) feat(core): added customer phone_number and email to session token response for click to pay (#6863) FEAT(klarna): Klarna Kustom Checkout Integration (#6839) feat(users): handle email url for users in different tenancies (#6809) chore(version): 2024.12.19.0 refactor(dynamic_routing): update the authentication for update config to include JWT type (#6785) chore(env): remove unified_authentication_service base_url from integ, sandbox and production toml (#6865)

…ete-pm * 'main' of github.com:juspay/hyperswitch: fix(connector): Update mandate PMT configs for Mandate Supported Connectors (#6903) fix(connector): [STRIPE] fix stripe mandate (#6899)

…ete-pm * 'main' of github.com:juspay/hyperswitch: chore(version): 2024.12.23.0 feat(connector): [JPMORGAN] add Payment flows for cards (#6668) refactor(grpc): send `x-tenant-id` and `x-request-id` in grpc headers (#6904) feat(payment_methods_v2): Added Ephemeral auth for v2 (#6813) chore(cypress): payout - fix test cases for adyenplatform bank (#6887) refactor(connector): [Airwallex] add device_data in payment request (#6881) feat(router): add db interface for `/relay` (#6879) feat(payments_v2): implement payments capture v2 (#6722) feat(router): add /relay endpoint (#6870)

pixincreate self-assigned this Dec 4, 2024

pixincreate added the A-CI-CD Area: Continuous Integration/Deployment label Dec 4, 2024

pixincreate added this to the December 2024 Release milestone Dec 4, 2024

pixincreate requested review from jagan-jaya and likhinbopanna December 4, 2024 08:37

pixincreate marked this pull request as ready for review December 4, 2024 08:40

pixincreate requested a review from a team as a code owner December 4, 2024 08:40

pixincreate marked this pull request as draft December 5, 2024 17:56

pixincreate force-pushed the cypress-delete-pm branch from 9290469 to 667357a Compare December 13, 2024 18:11

pixincreate marked this pull request as ready for review December 15, 2024 18:06

pixincreate changed the title ~~ci: add locker specific missing tests~~ ci: add locker tests Dec 16, 2024

pixincreate changed the title ~~ci: add locker tests~~ ci: add tests that make use of locker Dec 16, 2024

pixincreate requested a review from a team as a code owner December 16, 2024 10:24

pixincreate requested a review from SanchithHegde December 16, 2024 10:24

pixincreate mentioned this pull request Dec 16, 2024

fix(connector): add expiry year conversion for adyen mit transactions #6851

Merged

14 tasks

pixincreate added 11 commits December 17, 2024 18:51

ci: add delete payment method to cypress

018a12b

chore: rename files to make it meaning ful

f494d67

refactor: add more checks

67756a7

refactor: move response custom under get custom exchange

b08c769

feat: add mit payment for ntid based flows

89c31f1

doc: add an explanation of the flow and expectations

4926334

refactor: beautify

d732667

refactor: move mit auto capture to commons

a3562dd

fix: api keys not picking up properly when multiple creds are enabled

f0d26ce

fix: spec name being undefined

60c1e94

fix: create shared state instead of isolated env

89af9a3

pixincreate added 7 commits December 17, 2024 18:51

refactor: remvoe sharedState for globalState

28d4502

refactor: paymentIntent for adyen bank redirects need not be a `cus…

b237548

…tomExchange`

refactor: add validations and simplify the functions

e25c582

fix: v imp hot_fix

6e21745

chore: update dependencies

7c66214

fix: reports

f071242

chore: update creds to support multiple creds for stripe

3bd329b

jagan-jaya reviewed Dec 17, 2024

View reviewed changes

likhinbopanna reviewed Dec 17, 2024

View reviewed changes

pixincreate added 2 commits December 17, 2024 21:46

feat: add token based test for ntid

fb584f0

fix: globalState for multiple connectors

6c170a6

pixincreate force-pushed the cypress-delete-pm branch from 06d09b2 to 6c170a6 Compare December 17, 2024 16:17

pixincreate requested review from jagan-jaya and likhinbopanna December 17, 2024 16:34

jagan-jaya previously approved these changes Dec 18, 2024

View reviewed changes

refactor: add a check for existence of error code and message

f19226d

this is allow us to see the error message directly in the screenshot without us manually running the test

pixincreate dismissed jagan-jaya’s stale review via f19226d December 18, 2024 06:57

pixincreate added 2 commits December 18, 2024 12:51

refactor: error check

098d999

Revert "refactor: error check"

fb3a0de

This reverts commit 098d999.

pixincreate mentioned this pull request Dec 19, 2024

fix: cypress reports generation #6894

Merged

14 tasks

pixincreate added 2 commits December 19, 2024 15:50

revert: report fix and bump for #6894

4020693

Revert "refactor: add a check for existence of error code and message"

eaef641

This reverts commit f19226d.

pixincreate added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 19, 2024

pixincreate added 2 commits December 20, 2024 14:28

Merge branch 'main' of github.com:juspay/hyperswitch into cypress-del…

4a28603

…ete-pm * 'main' of github.com:juspay/hyperswitch: fix(connector): Update mandate PMT configs for Mandate Supported Connectors (#6903) fix(connector): [STRIPE] fix stripe mandate (#6899)

pixincreate requested a review from jagan-jaya December 20, 2024 12:22

jagan-jaya approved these changes Dec 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: add tests that make use of locker #6735

ci: add tests that make use of locker #6735

pixincreate commented Dec 4, 2024 •

edited

Loading

semanticdiff-com bot commented Dec 4, 2024 •

edited

Loading

likhinbopanna commented Dec 4, 2024

pixincreate commented Dec 4, 2024

pixincreate commented Dec 5, 2024

jagan-jaya Dec 17, 2024

pixincreate Dec 17, 2024 •

edited

Loading

likhinbopanna Dec 17, 2024

pixincreate Dec 17, 2024 •

edited

Loading

pixincreate commented Dec 19, 2024 •

edited

Loading

ci: add tests that make use of locker #6735

Are you sure you want to change the base?

ci: add tests that make use of locker #6735

Conversation

pixincreate commented Dec 4, 2024 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

semanticdiff-com bot commented Dec 4, 2024 • edited Loading

likhinbopanna commented Dec 4, 2024

pixincreate commented Dec 4, 2024

pixincreate commented Dec 5, 2024

jagan-jaya Dec 17, 2024

Choose a reason for hiding this comment

pixincreate Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

likhinbopanna Dec 17, 2024

Choose a reason for hiding this comment

pixincreate Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

pixincreate commented Dec 19, 2024 • edited Loading

pixincreate commented Dec 4, 2024 •

edited

Loading

semanticdiff-com bot commented Dec 4, 2024 •

edited

Loading

pixincreate Dec 17, 2024 •

edited

Loading

pixincreate Dec 17, 2024 •

edited

Loading

pixincreate commented Dec 19, 2024 •

edited

Loading