feat(payment): Add audit events for PaymentStart update #4800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaustubh1106
changed the title
kaustubh1106
changed the title
lsampras
reviewed
May 30, 2024
| @@ -219,6 +219,11 @@ impl<F: Clone> UpdateTracker<F, PaymentData<F>, api::PaymentsStartRequest> for P | |||
| where | |||
| F: 'b + Send, | |||
| { | |||
| _req_state | |||
There was a problem hiding this comment.
Suggested change
| _req_state | |
| req_state |
There was a problem hiding this comment.
hey @lsampras the passed variable is _req_state shouldn't we use it in that way only?? just asking, I am a beginner
| @@ -219,6 +219,11 @@ impl<F: Clone> UpdateTracker<F, PaymentData<F>, api::PaymentsStartRequest> for P | |||
| where | |||
| F: 'b + Send, | |||
| { | |||
| _req_state | |||
| .event_context | |||
| .event(AuditEvent::new(AuditEventType::PaymentStarted)) | |||
There was a problem hiding this comment.
Suggested change
| .event(AuditEvent::new(AuditEventType::PaymentStarted)) | |
| .event(AuditEvent::new(AuditEventType::PaymentStart)) |
lsampras
added
A-framework
kaustubh1106
force-pushed
the
paymentStartEventChanges
branch
from
4cc51fc to
f513c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
update the paymentstart implementation of updatetracker to generate an event
Additional Changes
Add audit events for PaymentStart update
following files have been changed:
crates/router/src/core/payments/operations/patment_start.rs
crates/router/src/events/audit_events.rs
Motivation and Context
#4681
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy