-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audit events for PaymentStart update #4681
Comments
Hey @lsampras , I would like to work on this issue, can you please assign this to me? |
@kaustubh1106 yeah you are right about the trait there, and you can add another variant in the same enum... |
@lsampras please review my PR |
@lsampras hey! can you please review and tell me if there is any other changes I have to make? |
hey @lsampras can you please clarify me about this https://github.com/juspay/hyperswitch/pull/4800/files/7b508ea5d4264ee576e1b0c9e58ed646b8ccc7ae#r1621028135 |
@lsampras sir can please tell me if there is something wrong with the PR? |
@kaustubh1106 no worries everything seems correct, I had approved the PR as well, |
@lsampras Check compilation on MSRV toolchain (ubuntu-latest) |
@kaustubh1106 you should be able to fix it by adding the suggested import |
@lsampras sir I have closed the last PR and created a new one after testing and formatting. Please reveiw if there are some changes needed |
@lsampras sir can you please review the PR |
Created from #4525
This covers adding events for PaymentStart operation
This event should include the payment data similar to PaymentCancel
It should also include any metadata for the event
e.g reason for payment rejection, error codes, rejection source etc
The text was updated successfully, but these errors were encountered: