Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audit events for PaymentStart update #4681

Open
Tracked by #4525
lsampras opened this issue May 17, 2024 · 13 comments · May be fixed by #5194
Open
Tracked by #4525

Add audit events for PaymentStart update #4681

lsampras opened this issue May 17, 2024 · 13 comments · May be fixed by #5194
Assignees

Comments

@lsampras
Copy link
Member

lsampras commented May 17, 2024

Created from #4525

This covers adding events for PaymentStart operation

This event should include the payment data similar to PaymentCancel

It should also include any metadata for the event
e.g reason for payment rejection, error codes, rejection source etc

@kaustubh1106
Copy link
Contributor

Hey @lsampras , I would like to work on this issue, can you please assign this to me?

@kaustubh1106
Copy link
Contributor

Hey @lsampras , I need some clarity as I gone through the reference #4166 ,I have to make changes in Pyament_update.rs in updateTracker trait ?? am I right? and also I want to ask do I need to add enum in Audit_event or I have to use any existing enum???

@lsampras
Copy link
Member Author

@kaustubh1106 yeah you are right about the trait there, and you can add another variant in the same enum...

@kaustubh1106
Copy link
Contributor

@lsampras please review my PR

@kaustubh1106
Copy link
Contributor

@lsampras hey! can you please review and tell me if there is any other changes I have to make?

@lsampras lsampras linked a pull request May 31, 2024 that will close this issue
14 tasks
@kaustubh1106
Copy link
Contributor

@kaustubh1106
Copy link
Contributor

@lsampras sir can please tell me if there is something wrong with the PR?

@lsampras
Copy link
Member Author

lsampras commented Jun 4, 2024

@kaustubh1106 no worries everything seems correct, I had approved the PR as well,
there's some CI failures, would you be able to take a look at that?

@kaustubh1106
Copy link
Contributor

@lsampras Check compilation on MSRV toolchain (ubuntu-latest)
Sir I am unable to fix this and
Screenshot 2024-06-04 at 5 10 32 PM
and following error req_state i think you suggested me

@lsampras
Copy link
Member Author

@kaustubh1106 you should be able to fix it by adding the suggested import
(use crate: events: :audit_events: :AuditEventType;),
can test it locally via make clippy

@kaustubh1106 kaustubh1106 linked a pull request Jul 3, 2024 that will close this issue
14 tasks
@kaustubh1106
Copy link
Contributor

@lsampras sir I have closed the last PR and created a new one after testing and formatting. Please reveiw if there are some changes needed

@kaustubh1106
Copy link
Contributor

@lsampras sir can you please review the PR

@kaustubh1106
Copy link
Contributor

@lsampras

@ivor11 ivor11 linked a pull request Jul 10, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants