Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [BANKOFAMERICA] Implement Apple Pay #3061

Merged
merged 6 commits into from
Dec 6, 2023
Merged

feat(connector): [BANKOFAMERICA] Implement Apple Pay #3061

merged 6 commits into from
Dec 6, 2023

Conversation

deepanshu-iiitu
Copy link
Contributor

@deepanshu-iiitu deepanshu-iiitu commented Dec 5, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Implement Payment Method Apple Pay for connector Bankofamerica

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

https://github.com/juspay/hyperswitch-cloud/issues/3541

How did you test it?

This is an apple pay pr and proper testing will be carried out on sandbox. For now testing was done by hardcoding the values.
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@deepanshu-iiitu deepanshu-iiitu requested a review from a team as a code owner December 5, 2023 14:42
@deepanshu-iiitu deepanshu-iiitu self-assigned this Dec 5, 2023
@deepanshu-iiitu deepanshu-iiitu added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Dec 5, 2023
@deepanshu-iiitu deepanshu-iiitu added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 5, 2023
@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Dec 6, 2023
@deepanshu-iiitu deepanshu-iiitu requested a review from a team as a code owner December 6, 2023 07:59
@deepanshu-iiitu deepanshu-iiitu removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Dec 6, 2023
ArjunKarthik
ArjunKarthik reviewed Dec 6, 2023
View reviewed changes
crates/router/src/connector/utils.rs Outdated Show resolved Hide resolved
crates/router/src/connector/utils.rs Outdated Show resolved Hide resolved
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 47c0383 Dec 6, 2023
14 of 16 checks passed
@Gnanasundari24 Gnanasundari24 deleted the boa-applepay branch December 6, 2023 10:10
@deepanshu-iiitu deepanshu-iiitu removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 7, 2023
deepanshu-iiitu added a commit that referenced this pull request Dec 20, 2023
@deepanshu-iiitu @hyperswitch-bot
feat(connector): [BANKOFAMERICA] Implement Apple Pay (#3061)
e5fa483 
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
@deepanshu-iiitu deepanshu-iiitu mentioned this pull request Dec 20, 2023
Merged
15 tasks
deepanshu-iiitu added a commit that referenced this pull request Dec 20, 2023
@deepanshu-iiitu @hyperswitch-bot
feat(connector): [BANKOFAMERICA] Implement Apple Pay (#3061)
bfbcbad 
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
@deepanshu-iiitu deepanshu-iiitu mentioned this pull request Dec 20, 2023
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@deepanshu-iiitu deepanshu-iiitu

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepanshu-iiitu @ArjunKarthik @ShankarSinghC @Gnanasundari24