Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [BOA] Add GPAY, ApplePay and other fixes #3174

Merged
merged 13 commits into from
Dec 20, 2023
Merged

feat(connector): [BOA] Add GPAY, ApplePay and other fixes #3174

merged 13 commits into from
Dec 20, 2023

Conversation

deepanshu-iiitu
Copy link
Contributor

@deepanshu-iiitu deepanshu-iiitu commented Dec 20, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

I have cherry-picked the following commits for production deployment:

  1. fix(core): Fix Default Values Enum FieldType #2934
  2. feat(connector): [BANKOFAMERICA] Implement Google Pay #2940
  3. fix(connector): [BANKOFAMERICA] Add status VOIDED in enum Bankofameri… #2969
  4. feat(connector): [BANKOFAMERICA] Add Required Fields for GPAY #3014
  5. feat(connector): [BANKOFAMERICA] Implement Apple Pay #3061
  6. fix(connector): [BOA/CYBERSOURCE] Update error handling #3156 (Only BOA changes from this PR 3156)

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Production hotfix

How did you test it?

The following payment methods need to be tested for Bank of America

  1. Cards-NON-3DS
  2. Google Pay
  3. Apple Pay

The following flows need to be tested for each of the above payment method.

  • Authorize
  • Capture
  • PSYNC
  • VOID
  • Refunds
  • RSYNC

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@deepanshu-iiitu deepanshu-iiitu requested review from a team as code owners December 20, 2023 08:23
@deepanshu-iiitu deepanshu-iiitu self-assigned this Dec 20, 2023
@deepanshu-iiitu deepanshu-iiitu added the A-connector-integration Area: Connector integration label Dec 20, 2023
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 20, 2023
@deepanshu-iiitu deepanshu-iiitu changed the title Boa prod hotfix 1.84 feat(connector): [BOA] Add GPAY ApplePay and other fixes Dec 20, 2023
@deepanshu-iiitu deepanshu-iiitu changed the title feat(connector): [BOA] Add GPAY ApplePay and other fixes feat(connector): [BOA] Add GPAY, ApplePay and other fixes Dec 20, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 20, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Dec 20, 2023
View reviewed changes
@deepanshu-iiitu deepanshu-iiitu requested a review from a team as a code owner December 20, 2023 09:28
ArjunKarthik
ArjunKarthik previously approved these changes Dec 20, 2023
View reviewed changes
@deepanshu-iiitu deepanshu-iiitu requested a review from a team as a code owner December 20, 2023 12:46
ArjunKarthik
ArjunKarthik previously approved these changes Dec 20, 2023
View reviewed changes
sai-harsha-vardhan
sai-harsha-vardhan approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed core changes

@bernard-eugine bernard-eugine merged commit ceae91e into hotfix-1.84.0 Dec 20, 2023
10 of 13 checks passed
@bernard-eugine bernard-eugine deleted the boa-prod-hotfix-1.84 branch December 20, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@deepanshu-iiitu deepanshu-iiitu

Labels
A-connector-integration Area: Connector integration
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deepanshu-iiitu @ArjunKarthik @sai-harsha-vardhan @bernard-eugine @Chethan-rao