feat(connector): [BANKOFAMERICA] Add Required Fields for GPAY #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepanshu-iiitu
added
A-connector-integration
|
@deepanshu-iiitu Please add proper test case. This is not self explanatory. |
prasunna09
requested changes
Nov 30, 2023
Comment on lines
2463
to
2471
| ( | ||
| "payment_method_data.card.card_holder_name".to_string(), | ||
| RequiredFieldInfo { | ||
| required_field: "payment_method_data.card.card_holder_name".to_string(), | ||
| display_name: "card_holder_name".to_string(), | ||
| field_type: enums::FieldType::UserFullName, | ||
| value: None, | ||
| } | ||
| ), |
There was a problem hiding this comment.
Suggested change
| ( | |
| "payment_method_data.card.card_holder_name".to_string(), | |
| RequiredFieldInfo { | |
| required_field: "payment_method_data.card.card_holder_name".to_string(), | |
| display_name: "card_holder_name".to_string(), | |
| field_type: enums::FieldType::UserFullName, | |
| value: None, | |
| } | |
| ), |
Can you please remove this? Since you have mentioned billing_first_name and billing_last_name, we can concatenate billing_first_name and last name at connector level. Ps: Billing details are tied to payment_method
There was a problem hiding this comment.
Can you remove this even in PaymentMethodType - Debit?
There was a problem hiding this comment.
yes, but are we already using billing_first_name + billing_last_name as card_holder_name?
There was a problem hiding this comment.
card_holder_name is not being used
There was a problem hiding this comment.
Then why was it added in the first place?
prasunna09
approved these changes
Nov 30, 2023
ArjunKarthik
approved these changes
Nov 30, 2023
deepanshu-iiitu
removed
the
S-waiting-on-review
deepanshu-iiitu
added a commit
that referenced
this pull request
Dec 20, 2023
15 tasks
deepanshu-iiitu
added a commit
that referenced
this pull request
Dec 20, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Following are the required fields for Google Pay Payments via Bank of America
Additional Changes
Motivation and Context
https://github.com/juspay/hyperswitch-cloud/issues/3297
How did you test it?
Test cases - Make a confirm false call, and make "list pm for merchant" call, in required fields, updated fields such as Billing first name, last name, line1, city, zip, country should show up for Bankofamerica
Checklist
cargo +nightly fmt --allcargo clippy