Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [Prophetpay] Use refund_id as reference_id for Refund #2966

Merged
merged 2 commits into from
Nov 23, 2023
Merged

fix(connector): [Prophetpay] Use refund_id as reference_id for Refund #2966

merged 2 commits into from
Nov 23, 2023

Conversation

Sakilmostak
Copy link
Contributor

@Sakilmostak Sakilmostak commented Nov 23, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Replaced connector_request_reference_id with refund_id for refund.
  • Removed response_code since we are not receiving it in case of failure
  • Made tranSeqNumber optional
    Closes #3353

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  • Craete a payment through Prophetpay Card Redirect
  • If it is successful, go the refund
  • The refund must be successful
Screenshot 2023-11-23 at 4 16 19 PM Screenshot 2023-11-23 at 4 16 25 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sakilmostak Sakilmostak requested a review from a team as a code owner November 23, 2023 11:24
@Sakilmostak Sakilmostak self-assigned this Nov 23, 2023
@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 23, 2023
@likhinbopanna likhinbopanna added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit dd3e22a Nov 23, 2023
29 of 36 checks passed
@likhinbopanna likhinbopanna deleted the prop_pay_fix_main branch November 23, 2023 12:22
@Sakilmostak Sakilmostak mentioned this pull request Nov 23, 2023
Merged
15 tasks
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@Sakilmostak Sakilmostak

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sakilmostak @ArjunKarthik @deepanshu-iiitu @SanchithHegde @likhinbopanna