Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [Prophetpay] Use refund_id as reference_id for Refund #2962

Merged
merged 2 commits into from
Nov 23, 2023
Merged

fix(connector): [Prophetpay] Use refund_id as reference_id for Refund #2962

merged 2 commits into from
Nov 23, 2023

Conversation

Sakilmostak
Copy link
Contributor

@Sakilmostak Sakilmostak commented Nov 23, 2023 •
edited by Chethan-rao
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Relative PR in main branch #2966

  • Replaced connector_request_reference_id with refund_id for refund.
  • Removed response_code since we are not receiving it in case of failure
  • Made tranSeqNumber optional

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Should test the refund
Screenshot 2023-11-23 at 4 16 19 PM

Screenshot 2023-11-23 at 4 16 25 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 23, 2023
@Sakilmostak Sakilmostak self-assigned this Nov 23, 2023
@Sakilmostak Sakilmostak requested a review from a team as a code owner November 23, 2023 10:49
ArjunKarthik
ArjunKarthik previously approved these changes Nov 23, 2023
View reviewed changes
@Sakilmostak Sakilmostak changed the title fix(connector): [Prophetpay] Use refund_id as reference_id for Refund fix(connector): [Prophetpay] Use refund_id as reference_id for Refund (Hotfix) Nov 23, 2023
@Sakilmostak Sakilmostak changed the title fix(connector): [Prophetpay] Use refund_id as reference_id for Refund (Hotfix) fix(connector): [Prophetpay] Use refund_id as reference_id for Refund Nov 23, 2023
@likhinbopanna likhinbopanna merged commit 29c9802 into hotfix-1.87.0 Nov 23, 2023
36 of 45 checks passed
@likhinbopanna likhinbopanna deleted the prop_refund_fix branch November 23, 2023 14:08
@likhinbopanna likhinbopanna removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@Sakilmostak Sakilmostak

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sakilmostak @ArjunKarthik @deepanshu-iiitu @likhinbopanna