-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mca): Add new auth_type
and a status field for mca
#2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMani
added
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Nov 16, 2023
jarnura
requested changes
Nov 16, 2023
jarnura
previously approved these changes
Nov 16, 2023
Narayanbhat166
approved these changes
Nov 17, 2023
apoorvdixit88
approved these changes
Nov 17, 2023
likhinbopanna
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Nov 17, 2023
likhinbopanna
approved these changes
Nov 17, 2023
lsampras
approved these changes
Nov 17, 2023
srujanchikke
approved these changes
Nov 17, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 17, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 17, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-compatibility
Area: Connector compatibility
C-feature
Category: Feature request or enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add a new
auth_type
calledTemporaryAuth
which describes that auth details are not yet received. When using thisauth_type
the connector status will beinactive
and mca will be disabled.Additional Changes
Motivation and Context
To support connector integration without auth details.
Closes #2895
How did you test it?
Postman.
Payment Connector - Create and Payment Connector - Update now supports a new auth type called
TemporaryAuth
and a new fieldstatus
.If
TemporaryAuth
is used in the request, the status field cannot beactive
and disabled cannot befalse
. This is applied for update mca as well. If a connector is inactive it cannot be enabled without changing the status to active.There are the following error messages that will be thrown if incorrect request is used.
If all the fields are passed correctly you will a normal mca response.
Checklist
cargo +nightly fmt --all
cargo clippy