Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mca): Change the check for disabled field in mca create and update #2938

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix(mca): Change the check for disabled field in mca create and update #2938

merged 1 commit into from
Nov 21, 2023

Conversation

ThisIsMani
Copy link
Contributor

@ThisIsMani ThisIsMani commented Nov 21, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Previously the check for disabled in mca_create and mca_update is matching on false instead of true. This PR fixes it.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Postman.
Same test cases as #2883.
Screenshot 2023-11-21 at 8 08 55 PM
Screenshot 2023-11-21 at 8 09 49 PM
Screenshot 2023-11-21 at 8 10 51 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ThisIsMani ThisIsMani added A-connector-compatibility Area: Connector compatibility C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 21, 2023
@ThisIsMani ThisIsMani added this to the November 2023 Release milestone Nov 21, 2023
@ThisIsMani ThisIsMani requested a review from a team as a code owner November 21, 2023 14:24
@ThisIsMani ThisIsMani self-assigned this Nov 21, 2023
@ThisIsMani ThisIsMani changed the title fix(mca): Change the check for disabled in mca fix(mca): Change the check for disabled field in mca create and update Nov 21, 2023
@ThisIsMani ThisIsMani requested a review from lsampras November 21, 2023 14:46
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit e66ccde Nov 21, 2023
16 of 18 checks passed
@Gnanasundari24 Gnanasundari24 deleted the connector-status branch November 21, 2023 15:21
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvdixit88 apoorvdixit88 apoorvdixit88 approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@Narayanbhat166 Narayanbhat166 Awaiting requested review from Narayanbhat166

@lsampras lsampras Awaiting requested review from lsampras

Assignees

@ThisIsMani ThisIsMani

Labels
A-connector-compatibility Area: Connector compatibility C-bug Category: Bug
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
November 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@ThisIsMani @sai-harsha-vardhan @apoorvdixit88 @SanchithHegde @Gnanasundari24