Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): [Shift4] change error message from NotSupported to NotImplemented #2880

Merged
merged 9 commits into from
Nov 30, 2023
Merged

refactor(connector): [Shift4] change error message from NotSupported to NotImplemented #2880

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
52f6e7d
[REFACTOR] : [Shift4] Error Message For Connector Implementation
unpervertedkid Nov 29, 2023
de11057
Removing repetition
unpervertedkid Nov 30, 2023
823c798
Remove duplication
unpervertedkid Nov 30, 2023
198271c
Remove duplication
unpervertedkid Nov 30, 2023
3930b07
Formatting
unpervertedkid Nov 30, 2023
54ca3bd
Merge branch 'main' into shift4/refactor-payment-error
unpervertedkid Nov 30, 2023
7c9509d
Merge branch 'main' into shift4/refactor-payment-error
unpervertedkid Nov 30, 2023
7960d9c
Merge branch 'main' into shift4/refactor-payment-error
unpervertedkid Nov 30, 2023
112b4ca
Merge branch 'main' into shift4/refactor-payment-error
unpervertedkid Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 21 additions & 28 deletions crates/router/src/connector/shift4/transformers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,9 @@ impl<T> TryFrom<&types::RouterData<T, types::PaymentsAuthorizeData, types::Payme
| payments::PaymentMethodData::Reward
| payments::PaymentMethodData::Upi(_)
| payments::PaymentMethodData::CardToken(_) => {
Err(errors::ConnectorError::NotSupported {
message: utils::SELECTED_PAYMENT_METHOD.to_string(),
connector: "Shift4",
}
Err(errors::ConnectorError::NotImplemented(
utils::get_unimplemented_payment_method_error_message("Shift4"),
)
.into())
}
}
Expand Down Expand Up @@ -212,10 +211,9 @@ impl TryFrom<&api_models::payments::WalletData> for Shift4PaymentMethod {
| payments::WalletData::TouchNGoRedirect(_)
| payments::WalletData::WeChatPayQr(_)
| payments::WalletData::CashappQr(_)
| payments::WalletData::SwishQr(_) => Err(errors::ConnectorError::NotSupported {
message: utils::SELECTED_PAYMENT_METHOD.to_string(),
connector: "Shift4",
}
| payments::WalletData::SwishQr(_) => Err(errors::ConnectorError::NotImplemented(
unpervertedkid marked this conversation as resolved.
Show resolved Hide resolved
utils::get_unimplemented_payment_method_error_message("Shift4"),
)
.into()),
}
}
Expand Down Expand Up @@ -244,10 +242,9 @@ impl TryFrom<&api_models::payments::BankTransferData> for Shift4PaymentMethod {
| payments::BankTransferData::DanamonVaBankTransfer { .. }
| payments::BankTransferData::MandiriVaBankTransfer { .. }
| payments::BankTransferData::Pix {}
| payments::BankTransferData::Pse {} => Err(errors::ConnectorError::NotSupported {
message: utils::SELECTED_PAYMENT_METHOD.to_string(),
connector: "Shift4",
}
| payments::BankTransferData::Pse {} => Err(errors::ConnectorError::NotImplemented(
unpervertedkid marked this conversation as resolved.
Show resolved Hide resolved
utils::get_unimplemented_payment_method_error_message("Shift4"),
)
.into()),
}
}
Expand All @@ -273,10 +270,9 @@ impl TryFrom<&api_models::payments::VoucherData> for Shift4PaymentMethod {
| payments::VoucherData::MiniStop(_)
| payments::VoucherData::FamilyMart(_)
| payments::VoucherData::Seicomart(_)
| payments::VoucherData::PayEasy(_) => Err(errors::ConnectorError::NotSupported {
message: utils::SELECTED_PAYMENT_METHOD.to_string(),
connector: "Shift4",
}
| payments::VoucherData::PayEasy(_) => Err(errors::ConnectorError::NotImplemented(
unpervertedkid marked this conversation as resolved.
Show resolved Hide resolved
utils::get_unimplemented_payment_method_error_message("Shift4"),
)
.into()),
}
}
Expand All @@ -286,10 +282,9 @@ impl TryFrom<&api_models::payments::GiftCardData> for Shift4PaymentMethod {
type Error = Error;
fn try_from(gift_card_data: &api_models::payments::GiftCardData) -> Result<Self, Self::Error> {
match gift_card_data {
payments::GiftCardData::Givex(_) => Err(errors::ConnectorError::NotSupported {
message: utils::SELECTED_PAYMENT_METHOD.to_string(),
connector: "Shift4",
}
payments::GiftCardData::Givex(_) => Err(errors::ConnectorError::NotImplemented(
unpervertedkid marked this conversation as resolved.
Show resolved Hide resolved
utils::get_unimplemented_payment_method_error_message("Shift4"),
)
.into()),
payments::GiftCardData::PaySafeCard {} => Err(errors::ConnectorError::NotImplemented(
utils::get_unimplemented_payment_method_error_message("Shift4"),
Expand Down Expand Up @@ -401,10 +396,9 @@ impl<T> TryFrom<&types::RouterData<T, types::CompleteAuthorizeData, types::Payme
| Some(payments::PaymentMethodData::Reward)
| Some(payments::PaymentMethodData::Upi(_))
| Some(api::PaymentMethodData::CardToken(_))
| None => Err(errors::ConnectorError::NotSupported {
message: "Flow".to_string(),
connector: "Shift4",
}
| None => Err(errors::ConnectorError::NotImplemented(
utils::get_unimplemented_payment_method_error_message("Shift4"),
)
.into()),
}
}
Expand Down Expand Up @@ -436,10 +430,9 @@ impl TryFrom<&payments::BankRedirectData> for PaymentMethodType {
| payments::BankRedirectData::OpenBankingUk { .. }
| payments::BankRedirectData::OnlineBankingFpx { .. }
| payments::BankRedirectData::OnlineBankingThailand { .. } => {
Err(errors::ConnectorError::NotSupported {
message: utils::SELECTED_PAYMENT_METHOD.to_string(),
connector: "Shift4",
}
Err(errors::ConnectorError::NotImplemented(
utils::get_unimplemented_payment_method_error_message("Shift4"),
)
.into())
}
}
Expand Down
Loading