Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): [Shift4] change error message from NotSupported to NotImplemented #2880

Merged
merged 9 commits into from
Nov 30, 2023
Merged

refactor(connector): [Shift4] change error message from NotSupported to NotImplemented #2880

merged 9 commits into from
Nov 30, 2023

Conversation

unpervertedkid
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Resolves #2860

How did you test it?

No test cases required. As In this PR only error message have been changed from Not Supported error message to NotImplemented error message.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@unpervertedkid unpervertedkid requested a review from a team as a code owner November 15, 2023 17:32
@unpervertedkid unpervertedkid marked this pull request as draft November 15, 2023 18:57
@swangi-kumari
Copy link
Contributor

Hey @unpervertedkid ,
Please resolve the conflicts from your branch.

@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers labels Nov 29, 2023
@unpervertedkid unpervertedkid marked this pull request as ready for review November 29, 2023 09:57
@unpervertedkid
Copy link
Contributor Author

@swangi-kumari should be good now.

@unpervertedkid
Copy link
Contributor Author

@swangi-kumari take a look at this iteration

swangi-kumari
swangi-kumari approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@swangi-kumari swangi-kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

SanchithHegde
SanchithHegde approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @unpervertedkid!

@SanchithHegde SanchithHegde added this pull request to the merge queue Nov 30, 2023
Merged via the queue into juspay:main with commit bc79d52 Nov 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swangi-kumari swangi-kumari swangi-kumari approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@unpervertedkid unpervertedkid

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] : [Shift4] Error Message For Connector Implementation
3 participants
@unpervertedkid @swangi-kumari @SanchithHegde