feat(connector): [Noon] Currency Unit Conversion #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagarDevAchar
force-pushed
the
noon_issue_2237
branch
from
eb52ec1 to
95a61a6
Compare
2 tasks
SanchithHegde
added
A-connector-integration
There was a problem hiding this comment.
@SagarDevAchar, please resolve the conflicts and implement currency conversion for payments capture flow
ConnectorIntegration<api::Capture, types::PaymentsCaptureData, types::PaymentsResponseData>
Comment on lines
656
to
+658
| amount: conn_utils::to_currency_base_unit( | ||
| item.request.refund_amount, | ||
| item.request.currency, | ||
| item.router_data.request.refund_amount, | ||
| item.router_data.request.currency, |
There was a problem hiding this comment.
Use item.amount, in place of to_currency_base_unit().
As in noon.rs we already call the tryfrom for currency conversion incase of Refund
Comment on lines
+386
to
+389
| amount: conn_utils::to_currency_base_unit( | ||
| item.router_data.request.amount, | ||
| item.router_data.request.currency, | ||
| )?, |
There was a problem hiding this comment.
Suggested change
| amount: conn_utils::to_currency_base_unit( | |
| item.router_data.request.amount, | |
| item.router_data.request.currency, | |
| )?, | |
| amount: item.amount.clone(), |
|
Hello @SagarDevAchar, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
hyperswitch/crates/router/src/connector/noon.rsget_currency_unitfunctionConnectorIntegrationimplementations forNoonnoon/transformers.rsNoonRouterData<T>structure and functionalityNoonPaymentsRequestAdditional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy