-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]: [Noon] Currency Unit Conversion #2237
Comments
Hello! I'd like to give this a shot. Would someone please assign it to me? Thank you! |
Hi @DostoevskyOnLinux , I have assigned this issue to you. |
Hmm. I can find another one to fix, I guess... |
Sorry, @Sakilmostak, @heckarman said he had a PR open to fix this one. It looks like he has closed it though... He had commented to say as much. Should I keep working on this? Thank you! |
@DostoevskyOnLinux, feel free to take my code. It should work without any issues and it's been tested to be working. |
Hey @DostoevskyOnLinux , |
Yes, I am! Sorry about the confusion. I've just been poking through the program, trying to make sure I understand what the changes are doing. Thank you for the offer! |
Hey, I'd like to work on this! |
Sure @SagarDevAchar, I'll assign this to you. |
Closing because currency conversion implementation have changed |
📝 Feature Description
to_currency_base_unit
andto_currency_lower_unit
in place to convert the minor unit amount to its decimal equivalent and vice versa. These conversions are handled explicitly based on the connector.🔨 Possible Implementation
get_currency_unit
method. This method needs to be implemented.connector_router_data
creation. Concurrently handle the creation ofconnector_router_data
to be passed for the connector request body creation.🔖 Note: All the changes needed should be contained within
hyperswitch/crates/router/src/connector/
📦 Have you spent some time checking if this feature request has been raised before?
📦 Have you read the Contributing Guidelines?
✨ Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: