-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(connector): [Worldpay] Currency Unit Conversion #2436
Merged
SanchithHegde
merged 18 commits into
juspay:main
from
Suraj3240:feature/worldpay_currency_unit_conversion
Oct 12, 2023
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1911011
Add currency conversion in Worldpay.rs
e448bf9
Update Worldpay/transformers.rs file
850cfcf
Solve amount issue
9180f74
remove commented line
7890aeb
modify transformers file
4be7bad
remove comments
f663804
Merge branch 'main' into feature/worldpay_currency_unit_conversion
ee1be16
remove extra dependencies
479c301
Merge branch 'main' into feature/worldpay_currency_unit_conversion
9f1bd38
import serde
37d5a7d
Merge branch 'main' into feature/worldpay_currency_unit_conversion
13b9a38
solve intergration connection errors
be04b77
Merge branch 'main' into feature/worldpay_currency_unit_conversion
0cc0c83
Update transformers.rs
Suraj3240 be6489f
format transformers.rs file
Suraj3240 5008f93
Merge branch 'main' into feature/worldpay_currency_unit_conversion
Suraj3240 dc66921
Merge branch 'main' into feature/worldpay_currency_unit_conversion
Suraj3240 a31cb97
Merge branch 'main' into feature/worldpay_currency_unit_conversion
Suraj3240 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,4 @@ | |
"devDependencies": { | ||
"newman": "git+ssh://[email protected]:knutties/newman.git#7106e194c15d49d066fa09d9a2f18b2238f3dba8" | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
amount
field needs to be retrieved from theWorldpayRouterData
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will solve the issue.
I will commit the changes said.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srujanchikke please check and inform if any further changes to be made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Suraj3240 Why do we need to match with
order_details
,As We are not usingorder details
anywhere in payment request ?Please refer to this pr for more info #2192
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I will have to code for all the payment methods like wallet,cards,etc. as given in this file, right?
And the amount will be like this, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to worry about the other payment methods mapping . But yes , as you mentioned amount should be mapped that way .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR link the fields are derived from the
Order_details
. And hence I used that method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And following the method used in this PR, it is giving out errors.
So pls someone kindly help me.