refactor(connector): [Worldpay] Currency Unit Conversion #2436

Suraj3240 · 2023-10-03T16:27:58Z

Type of Change

Description

This pull request implements the get_currency_unit from the ConnectorCommon trait for the Worldpay connector. This function allows connectors to declare their accepted currency unit as either Base or Minor. For Worldpay it accepts currency as Minor units.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Links to the files with corresponding changes.

crates\router\src\connector\worldpay.rs
crates\router\src\connector\worldpay\transformers.rs

Motivation and Context

Closes #2250.

How did you test it?

I tried setting up and testing using VS code and codesandbox but was not able to do it.
So kindly review the changes and do let me know if any further issues.

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible
I added a CHANGELOG entry if applicable

Suraj3240 · 2023-10-03T17:37:23Z

@knutties I have raised a PR. What do I need to do now?

srujanchikke · 2023-10-03T18:47:28Z

crates/router/src/connector/worldpay/transformers.rs

+        match
+        request.order_details.clone(){
+            Some(order_details)=>
+
        Ok(Self {
            instruction: Instruction {
                value: PaymentValue {


The amount field needs to be retrieved from the WorldpayRouterData

Suggested change

value: PaymentValue {

value: PaymentValue {

amount : item.amount ,

I think this will solve the issue.
I will commit the changes said.

The amount field needs to be retrieved from the WorldpayRouterData

@srujanchikke please check and inform if any further changes to be made.

@Suraj3240 Why do we need to match with order_details ,As We are not using order details anywhere in payment request ?

Please refer to this pr for more info #2192

@Suraj3240 Why do we need to match with order_details ,As We are not using order details anywhere in payment request ?

Please refer to this pr for more info #2192

So I will have to code for all the payment methods like wallet,cards,etc. as given in this file, right?

And the amount will be like this, right?

You don't have to worry about the other payment methods mapping . But yes , as you mentioned amount should be mapped that way .

@Suraj3240 Why do we need to match with order_details ,As We are not using order details anywhere in payment request ?

Please refer to this pr for more info #2192

In this PR link the fields are derived from the Order_details. And hence I used that method.

@Suraj3240 Why do we need to match with order_details ,As We are not using order details anywhere in payment request ?

Please refer to this pr for more info #2192

And following the method used in this PR, it is giving out errors.

So pls someone kindly help me.

srujanchikke

Please update the branch to ensure the spell check in the CI workflow functions properly.

crates/router/src/connector/worldpay.rs

srujanchikke · 2023-10-05T07:30:52Z

Hey @Suraj3240

Please use the following cargo commands -

cargo check --all-features
cargo clippy --all-features

ref - Cargo commands, and fix the errors thrown by clippy for the checks to pass .

Please run cargo +nightly fmt to fix failing formatting check

Suraj3240 · 2023-10-06T13:52:41Z

@srujanchikke can you confirm the changes made?

srujanchikke · 2023-10-06T14:06:16Z

@srujanchikke can you confirm the changes made?

Can you remove this additional package-lock.json, package.json files

Suraj3240 · 2023-10-06T14:16:01Z

@srujanchikke can you confirm the changes made?

Can you remove this additional package-lock.json, package.json files

@srujanchikke
Done

srujanchikke · 2023-10-07T06:29:32Z

Hey @Suraj3240

Please use the following cargo commands -

cargo check --all-features cargo clippy --all-features

ref - Cargo commands, and fix the errors thrown by clippy for the checks to pass .

Please run cargo +nightly fmt to fix failing formatting check

Hey @Suraj3240 ,

Could you run this commands locally , so that the checks won't fail after pushing code .

Suraj3240 · 2023-10-10T19:25:37Z

Hey @Suraj3240

Please use the following cargo commands -

cargo check --all-features cargo clippy --all-features

ref - Cargo commands, and fix the errors thrown by clippy for the checks to pass .

Please run cargo +nightly fmt to fix failing formatting check

cargo clippy commands is giving errors which are asking to modify codes in other files (apart from Worldpay files).
So do i have to change all the other files or just ignore those?

srujanchikke · 2023-10-11T12:11:09Z

Please run cargo +nightly fmt to fix failing formatting check and revert package.json file .Other than that looks good to me

srujanchikke

Looks good to me!

SanchithHegde

Looks good to me!

Thanks for the PR, @Suraj3240!

Suraj3240 · 2023-10-12T13:09:19Z

Thanks for your help and support throughout. :)) @srujanchikke @SanchithHegde

swangi-kumari · 2023-10-18T07:27:55Z

Hey @Suraj3240 ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Suraj added 2 commits October 3, 2023 20:41

Add currency conversion in Worldpay.rs

1911011

Update Worldpay/transformers.rs file

e448bf9

Suraj3240 requested a review from a team as a code owner October 3, 2023 16:27

github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 3, 2023

Suraj3240 changed the title ~~Feature/worldpay currency unit conversion~~ worldpay currency unit conversion Oct 3, 2023

Suraj3240 changed the title ~~worldpay currency unit conversion~~ worldpay_currency_unit_conversion Oct 3, 2023

Suraj3240 closed this Oct 3, 2023

Suraj3240 reopened this Oct 3, 2023

Suraj3240 changed the title ~~worldpay_currency_unit_conversion~~ Feature : Worldpay Currency Unit Conversion Oct 3, 2023

Suraj3240 changed the title ~~Feature : Worldpay Currency Unit Conversion~~ Feature:Worldpay Currency Unit Conversion Oct 3, 2023

Suraj3240 changed the title ~~Feature:Worldpay Currency Unit Conversion~~ Feature: Worldpay Currency Unit Conversion Oct 3, 2023

Suraj3240 changed the title ~~Feature: Worldpay Currency Unit Conversion~~ feature(connector): [Worldpay] Currency Unit Conversion Oct 3, 2023

Suraj3240 changed the title ~~feature(connector): [Worldpay] Currency Unit Conversion~~ refactor(connector): [Worldpay] Currency Unit Conversion Oct 3, 2023

github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 3, 2023

srujanchikke reviewed Oct 3, 2023

View reviewed changes

srujanchikke requested changes Oct 3, 2023

View reviewed changes

srujanchikke assigned Suraj3240 Oct 3, 2023

srujanchikke added A-connector-integration Area: Connector integration S-waiting-on-author Status: This PR is incomplete or needs to address review comments C-refactor Category: Refactor labels Oct 3, 2023

Solve amount issue

850cfcf

srujanchikke reviewed Oct 4, 2023

View reviewed changes

crates/router/src/connector/worldpay.rs Outdated Show resolved Hide resolved

VedantKhairnar added the hacktoberfest Issues that are up for grabs for Hacktoberfest participants label Oct 5, 2023

Suraj added 2 commits October 6, 2023 01:07

remove commented line

9180f74

modify transformers file

7890aeb

Suraj3240 force-pushed the feature/worldpay_currency_unit_conversion branch from 5e6d903 to 7890aeb Compare October 5, 2023 19:44

Suraj3240 requested review from jarnura and ashokkjag as code owners October 5, 2023 19:44

Merge branch 'main' into feature/worldpay_currency_unit_conversion

f663804

remove extra dependencies

ee1be16

Suraj3240 requested a review from srujanchikke October 6, 2023 15:40

Suraj added 3 commits October 7, 2023 17:33

Merge branch 'main' into feature/worldpay_currency_unit_conversion

479c301

import serde

9f1bd38

Merge branch 'main' into feature/worldpay_currency_unit_conversion

37d5a7d

Suraj3240 force-pushed the feature/worldpay_currency_unit_conversion branch from efa49e7 to 37d5a7d Compare October 7, 2023 19:51

Suraj and others added 3 commits October 11, 2023 00:57

solve intergration connection errors

13b9a38

Merge branch 'main' into feature/worldpay_currency_unit_conversion

be04b77

Update transformers.rs

0cc0c83

Suraj3240 added 4 commits October 11, 2023 13:58

format transformers.rs file

be6489f

Merge branch 'main' into feature/worldpay_currency_unit_conversion

5008f93

Merge branch 'main' into feature/worldpay_currency_unit_conversion

dc66921

Merge branch 'main' into feature/worldpay_currency_unit_conversion

a31cb97

srujanchikke approved these changes Oct 12, 2023

View reviewed changes

SanchithHegde approved these changes Oct 12, 2023

View reviewed changes

SanchithHegde added this pull request to the merge queue Oct 12, 2023

SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 12, 2023

Merged via the queue into juspay:main with commit b78109b Oct 12, 2023
10 checks passed

Suraj3240 deleted the feature/worldpay_currency_unit_conversion branch November 23, 2023 02:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(connector): [Worldpay] Currency Unit Conversion #2436

refactor(connector): [Worldpay] Currency Unit Conversion #2436

Suraj3240 commented Oct 3, 2023 •

edited by SanchithHegde

Loading

Suraj3240 commented Oct 3, 2023

srujanchikke Oct 3, 2023

Suraj3240 Oct 3, 2023

Suraj3240 Oct 3, 2023

srujanchikke Oct 4, 2023

Suraj3240 Oct 4, 2023

srujanchikke Oct 5, 2023

Suraj3240 Oct 5, 2023

Suraj3240 Oct 5, 2023

srujanchikke left a comment

srujanchikke commented Oct 5, 2023

Suraj3240 commented Oct 6, 2023

srujanchikke commented Oct 6, 2023

Suraj3240 commented Oct 6, 2023 •

edited

Loading

srujanchikke commented Oct 7, 2023

Suraj3240 commented Oct 10, 2023

srujanchikke commented Oct 11, 2023

srujanchikke left a comment

SanchithHegde left a comment

Suraj3240 commented Oct 12, 2023

swangi-kumari commented Oct 18, 2023

	value: PaymentValue {
	value: PaymentValue {
	amount : item.amount ,

refactor(connector): [Worldpay] Currency Unit Conversion #2436

refactor(connector): [Worldpay] Currency Unit Conversion #2436

Conversation

Suraj3240 commented Oct 3, 2023 • edited by SanchithHegde Loading

Type of Change

Description

Additional Changes

Links to the files with corresponding changes.

Motivation and Context

How did you test it?

Checklist

Suraj3240 commented Oct 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srujanchikke left a comment

Choose a reason for hiding this comment

srujanchikke commented Oct 5, 2023

Suraj3240 commented Oct 6, 2023

srujanchikke commented Oct 6, 2023

Suraj3240 commented Oct 6, 2023 • edited Loading

srujanchikke commented Oct 7, 2023

Suraj3240 commented Oct 10, 2023

srujanchikke commented Oct 11, 2023

srujanchikke left a comment

Choose a reason for hiding this comment

SanchithHegde left a comment

Choose a reason for hiding this comment

Suraj3240 commented Oct 12, 2023

swangi-kumari commented Oct 18, 2023

Suraj3240 commented Oct 3, 2023 •

edited by SanchithHegde

Loading

Suraj3240 commented Oct 6, 2023 •

edited

Loading