Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace if statements with switch in cardError code #771

Merged
merged 4 commits into from
Nov 12, 2024
Merged

refactor: replace if statements with switch in cardError code #771

merged 4 commits into from
Nov 12, 2024

Conversation

aritro2002
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

replaced if statements with switch in cardError code.

How did you test it?

By compiling code and also via rendering the SDK in chrome.

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

PritishBudhiraja
PritishBudhiraja reviewed Nov 6, 2024
View reviewed changes
src/Payment.res Outdated Show resolved Hide resolved
@PritishBudhiraja PritishBudhiraja added Ready for Review PR with label Ready for Review should only be reviewed. Added Comments - waiting for author Add this label when comments added in the PR and waiting for the author to get those resolved. labels Nov 6, 2024
@aritro2002 aritro2002 changed the title refactor: changed cardError code: replaced if statements with switch refactor:replaced if statements with switch in cardError code Nov 6, 2024
@aritro2002 aritro2002 changed the title refactor:replaced if statements with switch in cardError code refactor: replaced if statements with switch in cardError code Nov 6, 2024
@github-actions github-actions bot added S-conventions-not-followed Some Github conventions not followed and removed S-conventions-not-followed Some Github conventions not followed labels Nov 6, 2024
@aritro2002 aritro2002 changed the title refactor: replaced if statements with switch in cardError code refactor: replace if statements with switch in cardError code Nov 6, 2024
Sanskar2001
Sanskar2001 requested changes Nov 6, 2024
View reviewed changes
src/Payment.res Outdated Show resolved Hide resolved
@PritishBudhiraja PritishBudhiraja added Enhancement / Refactoring New feature or request or any refactoring and removed Added Comments - waiting for author Add this label when comments added in the PR and waiting for the author to get those resolved. labels Nov 8, 2024
PritishBudhiraja
PritishBudhiraja previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sanskar2001
Sanskar2001 requested changes Nov 8, 2024
View reviewed changes
src/Payment.res Show resolved Hide resolved
@PritishBudhiraja PritishBudhiraja merged commit e505d0a into main Nov 12, 2024
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the refactor/card-error branch November 12, 2024 13:28
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Enhancement / Refactoring New feature or request or any refactoring Ready for Review PR with label Ready for Review should only be reviewed. labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@Sanskar2001 Sanskar2001 Sanskar2001 approved these changes

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

Assignees

@aritro2002 aritro2002

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aritro2002 @Sanskar2001 @PritishBudhiraja