chore: add optimised code using switch

juspay · Nov 8, 2024 · 7b095d2 · 7b095d2
1 parent cf23ead
commit 7b095d2
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 18 deletions.
diff --git a/src/CardUtils.res b/src/CardUtils.res
@@ -675,3 +675,13 @@ let getEligibleCoBadgedCardSchemes = (~matchedCardSchemes, ~enabledCardSchemes)
 let getCardBrandFromStates = (cardBrand, cardScheme, showFields) => {
   !showFields ? cardScheme : cardBrand
 }
+
+let getCardBrandInvalidError = (
+  ~cardNumber,
+  ~localeString: OrcaPaymentPage.LocaleStringTypes.localeStrings,
+) => {
+  switch cardNumber->getCardBrand {
+  | "" => localeString.enterValidCardNumberErrorText
+  | cardBrandValue => localeString.cardBrandConfiguredErrorText(cardBrandValue)
+  }
+}
diff --git a/src/Payment.res b/src/Payment.res
@@ -328,25 +328,17 @@ let make = (~paymentMode, ~integrateError, ~logger) => {
   }, (cardNumber, cvcNumber, cardExpiry, isCVCValid, isExpiryValid, isCardValid))
 
   React.useEffect(() => {
-    let cardError = if isCardValid == None || cardNumber->String.length == 0 {
-      ""
-    } else {
-      let isCardSupportedValue = isCardSupported->Option.getOr(true)
-      let isCardValidValue = isCardValid->Option.getOr(false)
-
-      if isCardSupportedValue && isCardValidValue {
-        ""
-      } else if isCardSupportedValue {
-        localeString.inValidCardErrorText
-      } else {
-        let cardBrand = cardNumber->CardUtils.getCardBrand
-        if cardBrand == "" {
-          localeString.enterValidCardNumberErrorText
-        } else {
-          localeString.cardBrandConfiguredErrorText(cardBrand)
-        }
-      }
+    let cardError = switch (
+      isCardSupported->Option.getOr(true),
+      isCardValid->Option.getOr(true),
+      cardNumber->String.length == 0,
+    ) {
+    | (_, _, true) => ""
+    | (true, true, _) => ""
+    | (true, _, _) => localeString.inValidCardErrorText
+    | (_, _, _) => CardUtils.getCardBrandInvalidError(~cardNumber, ~localeString)
     }
+    let cardError = isCardValid->Option.isSome ? cardError : ""
     setCardError(_ => cardError)
     None
   }, [isCardValid, isCardSupported])