Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor PreMountLoader #583

Merged
merged 6 commits into from
Nov 6, 2024
Merged

refactor: refactor PreMountLoader #583

merged 6 commits into from
Nov 6, 2024

Conversation

seekshiva
Copy link
Collaborator

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Aug 26, 2024 •
edited
Loading

Review changes with  SemanticDiff

@PritishBudhiraja PritishBudhiraja added Enhancement / Refactoring New feature or request or any refactoring Ready for Review PR with label Ready for Review should only be reviewed. labels Nov 6, 2024
@PritishBudhiraja PritishBudhiraja removed the request for review from swamu November 6, 2024 09:50
sakksham7
sakksham7 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@sakksham7 sakksham7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally apple flow, normal card flow working fine

@PritishBudhiraja PritishBudhiraja merged commit 7c87c0c into main Nov 6, 2024
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the refactor-premount-loader branch November 6, 2024 09:55
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Enhancement / Refactoring New feature or request or any refactoring Ready for Review PR with label Ready for Review should only be reviewed. labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakksham7 sakksham7 sakksham7 approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

Assignees

@seekshiva seekshiva

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seekshiva @PritishBudhiraja @sakksham7