chore: comments addressed

juspay · Sep 3, 2024 · 2999f22 · 2999f22
1 parent ca29826
commit 2999f22
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/src/Payments/PreMountLoader.res b/src/Payments/PreMountLoader.res
@@ -57,13 +57,13 @@ module PreMountLoaderForElements = {
       )
 
       let messageHandler = (ev: Window.event) => {
-        let json = ev.data->Utils.safeParse
-        let dict = json->Utils.getDictFromJson
-        if dict->Dict.get("sendPaymentMethodsResponse")->Option.isSome {
+        open Utils
+        let dict = ev.data->safeParse->getDictFromJson
+        if dict->isKeyPresentInDict("sendPaymentMethodsResponse") {
           paymentMethodsPromise->sendPromiseData("payment_methods")
-        } else if dict->Dict.get("sendCustomerPaymentMethodsResponse")->Option.isSome {
+        } else if dict->isKeyPresentInDict("sendCustomerPaymentMethodsResponse") {
           customerPaymentMethodsPromise->sendPromiseData("customer_payment_methods")
-        } else if dict->Dict.get("sendSessionTokensResponse")->Option.isSome {
+        } else if dict->isKeyPresentInDict("sendSessionTokensResponse") {
           sessionTokensPromise->sendPromiseData("session_tokens")
         }
       }
@@ -88,9 +88,9 @@ module PreMountLoaderForPMMElements = {
       )
 
       let messageHandler = (ev: Window.event) => {
-        let json = ev.data->Utils.safeParse
-        let dict = json->Utils.getDictFromJson
-        if dict->Dict.get("sendSavedPaymentMethodsResponse")->Option.isSome {
+        open Utils
+        let dict = ev.data->safeParse->getDictFromJson
+        if dict->isKeyPresentInDict("sendSavedPaymentMethodsResponse") {
           savedPaymentMethodsPromise->sendPromiseData("saved_payment_methods")
         }
       }

diff --git a/src/Utilities/Utils.res b/src/Utilities/Utils.res
@@ -1372,3 +1372,5 @@ let getFirstAndLastNameFromFullName = fullName => {
 
   (firstName, lastNameJson)
 }
+
+let isKeyPresentInDict = (dict, key) => dict->Dict.get(key)->Option.isSome
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1372,3 +1372,5 @@ let getFirstAndLastNameFromFullName = fullName => {

		(firstName, lastNameJson)
		}

		let isKeyPresentInDict = (dict, key) => dict->Dict.get(key)->Option.isSome