Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pay now button text & theme based changes #223

Merged
merged 8 commits into from
Mar 13, 2024
Merged

fix: pay now button text & theme based changes #223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b8b33a7
fix: pay now button text
Mar 12, 2024
ab53eaf
fix: displaySavedPaymentMethods prop
Mar 12, 2024
b0c88fe
fix: theme based issue
Mar 12, 2024
414b5e7
fix: useEffect changes comment
Mar 13, 2024
d646e04
fix: saved PM rendering issue on displaySavedPaymentMethods
Mar 13, 2024
95f00f6
fix: warnings removed
Mar 13, 2024
a6ae6fa
fix: comments addressed
Mar 13, 2024
369452c
fix: comments addressed
Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Components/PayNowButton.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@ let make = (
Utils.handlePostMessage([("handleSdkConfirm", confirmPayload)])
}

let buttonText =
sdkHandleConfirmPayment.buttonText->String.length > 0
? sdkHandleConfirmPayment.buttonText
: localeString.payNowButton

React.useEffect4(() => {
if showFields {
if selectedOption === Card {
Expand Down Expand Up @@ -104,7 +109,7 @@ let make = (
{if showLoader {
<Loader />
} else {
localeString.payNowButton->React.string
buttonText->React.string
}}
</span>
</button>
Expand Down
3 changes: 3 additions & 0 deletions src/Types/PaymentType.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ type billingAddress = {

type sdkHandleConfirmPayment = {
handleConfirm: bool,
buttonText: string,
confirmParams: ConfirmType.confirmParams,
}

Expand Down Expand Up @@ -259,6 +260,7 @@ let defaultBillingAddress = {

let defaultSdkHandleConfirmPayment = {
handleConfirm: false,
buttonText: "",
confirmParams: ConfirmType.defaultConfirm,
}

Expand Down Expand Up @@ -896,6 +898,7 @@ let getConfirmParams = dict => {

let getSdkHandleConfirmPaymentProps = dict => {
handleConfirm: dict->getBool("handleConfirm", false),
buttonText: dict->getString("buttonText", ""),
confirmParams: dict->getDictfromDict("confirmParams")->getConfirmParams,
}

Expand Down
Loading