-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pay now button text & theme based changes #223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PritishBudhiraja
requested review from
prafulkoppalkar,
akash-c-k and
ArushKapoorJuspay
as code owners
March 12, 2024 13:18
vsrivatsa-edinburgh
previously approved these changes
Mar 12, 2024
akash-c-k
previously approved these changes
Mar 12, 2024
PritishBudhiraja
dismissed stale reviews from akash-c-k and vsrivatsa-edinburgh
via
March 12, 2024 14:33
ab53eaf
PritishBudhiraja
changed the title
fix: pay now button text
fix: pay now button text & theme based changes
Mar 12, 2024
akash-c-k
reviewed
Mar 13, 2024
src/PaymentElement.res
Outdated
let paymentLabel = showFields | ||
? localeString.selectPaymentMethodLabel | ||
: localeString.savedPaymentMethodsLabel | ||
React.useEffect0(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a dependency here on paymentMethods?
cc: @prafulkoppalkar @vsrivatsa-juspay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
seekshiva
approved these changes
Mar 13, 2024
akash-c-k
approved these changes
Mar 13, 2024
akash-c-k
pushed a commit
that referenced
this pull request
Mar 13, 2024
## [0.31.6](v0.31.5...v0.31.6) (2024-03-13) ### Bug Fixes * pay now button text & theme based changes ([#223](#223)) ([993767f](993767f))
rising-dragon401
added a commit
to rising-dragon401/hyperswitch-web
that referenced
this pull request
Jul 2, 2024
## [0.31.6](juspay/hyperswitch-web@v0.31.5...v0.31.6) (2024-03-13) ### Bug Fixes * pay now button text & theme based changes ([#223](juspay/hyperswitch-web#223)) ([993767f](juspay/hyperswitch-web@993767f))
ArushKapoorJuspay
pushed a commit
that referenced
this pull request
Sep 23, 2024
Merge in EXC/orca-elements from husky-hooks-semantic to main * commit 'c938a076fd8abf719f5c4ade784f8f4273f420cd': feat: HS-126: added husky hooks and semantic-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pay Now Button Text & theme based changes