Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: props divide disableSave cards to checkbox and api #206

Conversation

PritishBudhiraja
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja commented Mar 6, 2024

Add new props instead of disableSaveCards -

  1. displaySavedPaymentMethodsCheckbox
  2. displaySavedPaymentMethods

Default will be true and merchant can disable that via passing these as false.

@PritishBudhiraja PritishBudhiraja changed the title feat: props divide disableSave cards to Checkbox and api feat: props divide disableSave cards to checkbox and api Mar 8, 2024
Pritish Budhiraja added 2 commits March 8, 2024 18:22
…r-api-and-checkbox-different' of github.com:juspay/hyperswitch-web into 204-divide-the-disablesavecards-props-into-two-props-for-api-and-checkbox-different
Copy link
Contributor

@prafulkoppalkar prafulkoppalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the comments rest looks fine

Pritish Budhiraja added 4 commits March 8, 2024 19:04
Copy link
Contributor

@prafulkoppalkar prafulkoppalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging this

@prafulkoppalkar prafulkoppalkar merged commit 83426ab into main Mar 11, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the 204-divide-the-disablesavecards-props-into-two-props-for-api-and-checkbox-different branch March 11, 2024 19:47
akash-c-k pushed a commit that referenced this pull request Mar 11, 2024
# [0.29.0](v0.28.0...v0.29.0) (2024-03-11)

### Features

* props divide disableSave cards to checkbox and api ([#206](#206)) ([83426ab](83426ab))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
# [0.29.0](juspay/hyperswitch-web@v0.28.0...v0.29.0) (2024-03-11)

### Features

* props divide disableSave cards to checkbox and api ([#206](juspay/hyperswitch-web#206)) ([83426ab](juspay/hyperswitch-web@83426ab))
ArushKapoorJuspay pushed a commit that referenced this pull request Sep 23, 2024
Merge in EXC/orca-elements from errorBoundaryComponent to master

* commit '95f45d53bb3bf94f35b31ce8d3eaaea181fef970':
  emoji change
  sending logs to grafana and handling for payment request button
  error boundary component added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divide the disableSaveCards props into two props for API and Checkbox different
3 participants