Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divide the disableSaveCards props into two props for API and Checkbox different #204

Closed
PritishBudhiraja opened this issue Mar 6, 2024 · 0 comments · Fixed by #206
Closed

Divide the disableSaveCards props into two props for API and Checkbox different #204

PritishBudhiraja opened this issue Mar 6, 2024 · 0 comments · Fixed by #206
Assignees
@PritishBudhiraja
Labels
Enhancement / Refactoring New feature or request or any refactoring

Comments

@PritishBudhiraja
Copy link
Collaborator

Add new props instead of disableSaveCards -

  1. displaySavedPaymentMethodsCheckbox
  2. displaySavedPaymentMethods

Default will be true and merchant can disable that via passing these as false.
@PritishBudhiraja PritishBudhiraja self-assigned this Mar 6, 2024
@PritishBudhiraja PritishBudhiraja added the Enhancement / Refactoring New feature or request or any refactoring label Mar 6, 2024
@PritishBudhiraja PritishBudhiraja linked a pull request Mar 6, 2024 that will close this issue
feat: props divide disableSave cards to checkbox and api #206
Merged
ArushKapoorJuspay added a commit that referenced this issue Sep 23, 2024
@ArushKapoorJuspay @prafulkoppalkar
Pull request #204: Added Logs for the API Call Failure
46638b7 
Merge in EXC/orca-elements from fix/log-api-calls to master

* commit '47e6da8c2fc16bda4fc7870375f4e4cff0e1babf':
  Length check changes to > 0
  Resolved comments
  Removed _failed event names
  Removed batching
  Refactor API call logs
  Merge branch 'fix/log-api-calls' of ssh://ssh.bitbucket.juspay.net/exc/orca-elements into bugfixes/sdk_logs_formats
  Changed status code for no response
  Reformatted logs
  Added Logs for the API Call Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PritishBudhiraja PritishBudhiraja

Labels
Enhancement / Refactoring New feature or request or any refactoring
Projects
None yet
Milestone
No milestone
1 participant
@PritishBudhiraja