-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support to handle confirm button (E2E) #198
feat: Support to handle confirm button (E2E) #198
Conversation
f73c060
to
f96f5f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey i think lot of lines will be reduced if you keep the customization in a single object
it also ease the process of customization and reduces confusion
DevX is enhanced
Updated @prafulkoppalkar . Please recheck the PR |
0d132a8
to
3eb2e2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine merging this
3eb2e2e
to
fdd1412
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine merging this
# [0.30.0](v0.29.1...v0.30.0) (2024-03-11) ### Features * Support to handle confirm button (E2E) ([#198](#198)) ([a4ffecf](a4ffecf))
# [0.30.0](juspay/hyperswitch-web@v0.29.1...v0.30.0) (2024-03-11) ### Features * Support to handle confirm button (E2E) ([#198](juspay/hyperswitch-web#198)) ([a4ffecf](juspay/hyperswitch-web@a4ffecf))
…fo element based on rtl Merge in EXC/orca-elements from feat/error-language-support to master * commit 'c3c700a725334e1039cd43b7bd2b720002c76b00': Added Language support for card errors and flip info element based on rtl
Updated with this in themeObject -
and
sdkHandleConfirmPayment
will hold this