fix: comments addressed

juspay · Mar 11, 2024 · 0d132a8 · 0d132a8
1 parent dee4452
commit 0d132a8
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/src/Components/PayNowButton.res b/src/Components/PayNowButton.res
@@ -37,11 +37,6 @@ let make = (
     isExpiryValid->Option.getOr(false) &&
     areRequiredFieldsValidValue
 
-  let buttonText =
-    sdkHandleConfirmPayment.buttonText->String.length > 0
-      ? sdkHandleConfirmPayment.buttonText
-      : localeString.payNowButton
-
   let confirmPayload = sdkHandleConfirmPayment->PaymentBody.confirmPayloadForSDKButton
 
   let handleOnClick = _ => {
@@ -84,7 +79,7 @@ let make = (
         {if showLoader {
           <Loader />
         } else {
-          buttonText->React.string
+          localeString.payNowButton->React.string
         }}
       </span>
     </button>

diff --git a/src/LoaderController.res b/src/LoaderController.res
@@ -1,5 +1,4 @@
 open Utils
-external toJson: 'a => Js.Json.t = "%identity"
 
 @react.component
 let make = (~children, ~paymentMode, ~setIntegrateErrorError, ~logger) => {

diff --git a/src/Types/PaymentType.res b/src/Types/PaymentType.res
@@ -132,7 +132,6 @@ type billingAddress = {
 
 type sdkHandleConfirmPayment = {
   handleConfirm: bool,
-  buttonText: string,
   confirmParams: ConfirmType.confirmParams,
 }
 
@@ -255,7 +254,6 @@ let defaultBillingAddress = {
 
 let defaultSdkHandleConfirmPayment = {
   handleConfirm: false,
-  buttonText: "Pay Now",
   confirmParams: ConfirmType.defaultConfirm,
 }
 
@@ -884,7 +882,6 @@ let getConfirmParams = dict => {
 
 let getSdkHandleConfirmPaymentProps = dict => {
   handleConfirm: dict->getBool("handleConfirm", false),
-  buttonText: dict->getString("buttonText", "Pay Now"),
   confirmParams: dict->getDictfromDict("confirmParams")->getConfirmParams,
 }