fix: comments addressed

juspay · Dec 5, 2024 · 4bbb062 · 4bbb062
1 parent 018e37b
commit 4bbb062
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 15 deletions.
diff --git a/src/CardTheme.res b/src/CardTheme.res
@@ -97,6 +97,7 @@ let getLocaleObject = async string => {
     | NL => Js.import(DutchLocale.localeStrings)
     | SV => Js.import(SwedishLocale.localeStrings)
     | RU => Js.import(RussianLocale.localeStrings)
+    | ZH_HANT => Js.import(TraditionalChineseLocale.localeStrings)
     }
 
     let awaitedLocaleValue = await promiseLocale

diff --git a/src/Payments/PazeWallet.res b/src/Payments/PazeWallet.res
@@ -113,19 +113,19 @@ let make = (~logger: HyperLogger.loggerMake) => {
               resolve()
             }
           }
-          logger.setLogInfo(~value="Paze SDK Script Loading", ~eventName=PAZE_SDK_FLOW)
+          logger.setLogInfo(~value="PAZE SDK Script Loading", ~eventName=PAZE_SDK_FLOW)
           let pazeScript = Window.createElement("script")
           pazeScript->Window.elementSrc(pazeScriptURL)
           pazeScript->Window.elementOnerror(exn => {
-            let err = exn->Identity.anyTypeToJson->JSON.stringify
             logger.setLogError(
-              ~value=`Error During Loading Paze SDK Script: ${err}`,
+              ~value=`Error During Loading PAZE SDK Script: ${exn
+                ->Identity.anyTypeToJson
+                ->JSON.stringify}`,
               ~eventName=PAZE_SDK_FLOW,
             )
-            Console.log2("PAZE --- errrorrr", err)
           })
           pazeScript->Window.elementOnload(_ => {
-            logger.setLogInfo(~value="Pzae SDK Script Loaded", ~eventName=PAZE_SDK_FLOW)
+            logger.setLogInfo(~value="PAZE SDK Script Loaded", ~eventName=PAZE_SDK_FLOW)
             loadPazeSDK()->ignore
           })
           Window.body->Window.appendChild(pazeScript)

diff --git a/src/Payments/SamsungPayComponent.res b/src/Payments/SamsungPayComponent.res
@@ -30,7 +30,7 @@ let make = (~sessionObj: option<JSON.t>, ~walletOptions) => {
   let onSamsungPaymentButtonClick = _ => {
     loggerState.setLogInfo(
       ~value="SamsungPay Button Clicked",
-      ~eventName=SAMSUNG_PAY_FLOW,
+      ~eventName=SAMSUNG_PAY,
       ~paymentMethod="SAMSUNG_PAY",
     )
     SamsungPayHelpers.handleSamsungPayClicked(

diff --git a/src/hyper-loader/Elements.res b/src/hyper-loader/Elements.res
@@ -1179,8 +1179,8 @@ let make = (
                     })
                     ->catch(err => {
                       logger.setLogError(
-                        ~value=err->formatException->JSON.stringify,
-                        ~eventName=SAMSUNG_PAY_FLOW,
+                        ~value=`SAMSUNG PAY not ready ${err->formatException->JSON.stringify}`,
+                        ~eventName=SAMSUNG_PAY,
                         ~paymentMethod="SAMSUNG_PAY",
                         ~logType=ERROR,
                       )
@@ -1209,8 +1209,10 @@ let make = (
                         })
                         ->catch(err => {
                           logger.setLogError(
-                            ~value=err->formatException->JSON.stringify,
-                            ~eventName=SAMSUNG_PAY_FLOW,
+                            ~value=`SAMSUNG PAY Initialization fail ${err
+                              ->formatException
+                              ->JSON.stringify}`,
+                            ~eventName=SAMSUNG_PAY,
                             ~paymentMethod="SAMSUNG_PAY",
                             ~logType=ERROR,
                           )
@@ -1230,17 +1232,17 @@ let make = (
                   } catch {
                   | err =>
                     logger.setLogError(
-                      ~value=err->formatException->JSON.stringify,
-                      ~eventName=SAMSUNG_PAY_FLOW,
+                      ~value=`SAMSUNG PAY Not Ready - ${err->formatException->JSON.stringify}`,
+                      ~eventName=SAMSUNG_PAY,
                       ~paymentMethod="SAMSUNG_PAY",
                       ~logType=ERROR,
                     )
                     Console.log("Error loading Samsung Pay")
                   }
                 } else if wallets.samsungPay === Never {
                   logger.setLogInfo(
-                    ~value="SamsungPay is set as never by merchant",
-                    ~eventName=SAMSUNG_PAY_FLOW,
+                    ~value="SAMSUNG PAY is set as never by merchant",
+                    ~eventName=SAMSUNG_PAY,
                     ~paymentMethod="SAMSUNG_PAY",
                     ~logType=INFO,
                   )

diff --git a/src/hyper-log-catcher/HyperLogger.res b/src/hyper-log-catcher/HyperLogger.res
@@ -88,7 +88,7 @@ type eventName =
   | POST_SESSION_TOKENS_CALL_INIT
   | PAZE_SDK_FLOW
   | SAMSUNG_PAY_SCRIPT
-  | SAMSUNG_PAY_FLOW
+  | SAMSUNG_PAY
 
 let eventNameToStrMapper = (eventName: eventName) => (eventName :> string)