Skip to content

Add missing "Open..." file menu #2056

Add missing "Open..." file menu

Add missing "Open..." file menu #2056

Triggered via pull request May 31, 2024 12:23
Status Failure
Total duration 10m 36s
Artifacts 7

ui-tests.yml

on: pull_request
Matrix: ui-tests
Fit to window
Zoom out
Zoom in

Annotations

12 errors and 3 notices
[chromium] › test/editor.spec.ts:35:7 › Editor › Renaming the file by clicking on the title: ui-tests/test/editor.spec.ts#L1
1) [chromium] › test/editor.spec.ts:35:7 › Editor › Renaming the file by clicking on the title ─── Test timeout of 60000ms exceeded.
[chromium] › test/editor.spec.ts:35:7 › Editor › Renaming the file by clicking on the title: ui-tests/test/editor.spec.ts#L23
1) [chromium] › test/editor.spec.ts:35:7 › Editor › Renaming the file by clicking on the title ─── Error: proxy.waitForNavigation: Test timeout of 60000ms exceeded. =========================== logs =========================== waiting for navigation until "load" ============================================================ 21 | await page.click('text="Rename"'), 22 | // wait until the URL is updated > 23 | await page.waitForNavigation(), | ^ 24 | ]); 25 | }; 26 | at processRenameDialog (/home/runner/work/notebook/notebook/ui-tests/test/editor.spec.ts:23:16) at /home/runner/work/notebook/notebook/ui-tests/test/editor.spec.ts:46:5
[chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page: ui-tests/test/mobile.spec.ts#L71
2) [chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page Error: Screenshot comparison failed: 306 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/notebook-chromium-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-chromium/notebook-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-chromium/notebook-diff.png 69 | } 70 | > 71 | expect(await notebook.screenshot()).toMatchSnapshot('notebook.png'); | ^ 72 | await notebook.close(); 73 | }); 74 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:71:41
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file: ui-tests/test/filebrowser.spec.ts#L39
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ──────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Open') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Open') 37 | 38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => { > 39 | expect(toolbar.getByText(text)).toBeVisible(); | ^ 40 | }); 41 | }); 42 | at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39) at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders: ui-tests/test/filebrowser.spec.ts#L55
2) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ─────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 53 | expect(toolbar.getByText('Rename')).toBeHidden(); 54 | expect(toolbar.getByText('Open')).toBeHidden(); > 55 | expect(toolbar.getByText('Delete')).toBeVisible(); | ^ 56 | }); 57 | 58 | test('Select files and open', async ({ page, tmpPath }) => { at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
[firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File: ui-tests/test/menus.spec.ts#L47
1) [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File ──────────────────── Error: Screenshot comparison failed: 1 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-file-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox/opened-menu-file-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox/opened-menu-file-diff.png 45 | const menu = await page.menu.getOpenMenu(); 46 | expect(menu).toBeDefined(); > 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase()); | ^ 48 | }); 49 | }); 50 | }); at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
[firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File: ui-tests/test/menus.spec.ts#L47
1) [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File ──────────────────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 1 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-file-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox-retry1/opened-menu-file-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox-retry1/opened-menu-file-diff.png 45 | const menu = await page.menu.getOpenMenu(); 46 | expect(menu).toBeDefined(); > 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase()); | ^ 48 | }); 49 | }); 50 | }); at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
[firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page: ui-tests/test/mobile.spec.ts#L71
2) [firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page Error: Screenshot comparison failed: 300 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-firefox/notebook-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-firefox/notebook-diff.png 69 | } 70 | > 71 | expect(await notebook.screenshot()).toMatchSnapshot('notebook.png'); | ^ 72 | await notebook.close(); 73 | }); 74 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:71:41
[firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page: ui-tests/test/mobile.spec.ts#L71
2) [firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 300 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-firefox-retry1/notebook-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-firefox-retry1/notebook-diff.png 69 | } 70 | > 71 | expect(await notebook.screenshot()).toMatchSnapshot('notebook.png'); | ^ 72 | await notebook.close(); 73 | }); 74 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:71:41
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file: ui-tests/test/filebrowser.spec.ts#L39
3) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ──────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Open') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Open') 37 | 38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => { > 39 | expect(toolbar.getByText(text)).toBeVisible(); | ^ 40 | }); 41 | }); 42 | at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39) at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders: ui-tests/test/filebrowser.spec.ts#L55
4) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ─────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 53 | expect(toolbar.getByText('Rename')).toBeHidden(); 54 | expect(toolbar.getByText('Open')).toBeHidden(); > 55 | expect(toolbar.getByText('Delete')).toBeVisible(); | ^ 56 | }); 57 | 58 | test('Select files and open', async ({ page, tmpPath }) => { at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
ui-tests (firefox)
Process completed with exit code 1.
🎭 Playwright Run Summary
2 flaky [chromium] › test/editor.spec.ts:35:7 › Editor › Renaming the file by clicking on the title ──── [chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page 33 passed (2.0m)
🎭 Playwright Run Summary
2 flaky [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ───────────────────── [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ──────────── 33 passed (2.0m)
🎭 Playwright Run Summary
2 failed [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File ───────────────────── [firefox] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page 2 flaky [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ───────────────────── [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ──────────── 31 passed (2.3m)

Artifacts

Produced during runtime
Name Size
notebook-chromium-test-assets Expired
1.61 MB
notebook-chromium-test-report Expired
2.24 MB
notebook-dist-2056 Expired
10.5 MB
notebook-firefox-test-assets Expired
3.46 MB
notebook-firefox-test-report Expired
4.03 MB
notebook-firefox-updated-snapshots Expired
360 KB
notebook-pkgs-2056 Expired
56.9 KB