Add missing "Open..." file menu #7385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Bot update playwright snapshots! |
krassowski
reviewed
May 30, 2024
Co-authored-by: Michał Krassowski <[email protected]>
|
Trigger CI |
|
These workflow failures (cancelled) are also happening on other PRs, and pass after restarting them, not sure why:
|
jtpio
reviewed
May 30, 2024
ui-tests/test/mobile.spec.ts-snapshots/notebook-firefox-linux.png
Outdated
Show resolved
Hide resolved
jtpio
reviewed
May 30, 2024
|
As mentioned above in #7385 (review), we probably need to revert the snapshot update related to the flaky test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Notebook 7, the
Open...menu disappeared, this PR brings it back.Notebook <=6 behavior:
https://github.com/jupyter/notebook/assets/21197331/89f09978-3338-4d3f-a913-592dceab9d92
Notebook 7 with this PR:
https://github.com/jupyter/notebook/assets/21197331/4acc8da0-c351-4118-9ac4-38b0bb4d1fe9