Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add single panda #1799
add single panda #1799
Changes from 4 commits
017a34d
2479817
aa2f556
c943a29
d19204b
7a093af
dfa63af
3a79e15
74fc6e4
0c7347b
21dcf54
0a7fad9
9dfe6fb
c0bba79
65cc004
c6164d9
6abfe11
3ff3fd7
39c9c2e
e677731
499d90d
0066eb7
fc875a0
66b1e5e
b1460d4
f58e301
aacbf62
653bb9b
408bce5
5f3c673
b555196
0a34501
72a2bc6
141b6cf
f8d3cc4
e7e82d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reset-pose
seems different fromjsk_robot/jsk_panda_robot/panda_eus/models/dual_panda.yaml
Lines 32 to 34 in 9391924
Also,
reset-pose
andreset-manip-pose
are the same.Do you have any reason why you choose this angle-vector as
reset-pose
andreset-manip-pose
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reasons of
reset pose
is coming from:In terms of using the same angle-vector in two poses, there is no deeper reasons.
I never used
reset-manip-pose
so far, so just set the same.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In yuki-asano#1, I added notice about the difference of
reset-pose
andreset-manip-pose
(and alsoend-coords
) to READMEThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After yuki-asano#3,
pannda
anddual_panda
use the sameend-coords
.