Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ModalForm.php #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update ModalForm.php #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21e9c5b
Update ModalForm.php
ayrzDev Nov 5, 2023
62573e6
Update ModalForm.php
ayrzDev Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/jojoe77777/FormAPI/ModalForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,17 @@ public function __construct(?callable $callable) {
$this->data["button2"] = "";
}

public function processData(&$data) : void {
if(!is_bool($data)) {
throw new FormValidationException("Expected a boolean response, got " . gettype($data));
// The error related to the "Esc" key has been fixed

public function processData(&$data): void
{
if ($data === null) {
$data = null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pointless

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It prevents you from getting a nasty error in the console. I don't understand what makes sense. Can you give a more detailed answer?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this branch is entered, $data is already null, so this assignment is doing nothing useful.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is overlooked in this plugin is that you get an error when you press the escape key. When the data is empty, either yes or no must be selected, so I added something like this to prevent an error if the data is empty.

return;
}

if (!is_bool($data)) {
throw new FormValidationException("Expected an integer response, got " . gettype($data));
}
}

Expand Down