Update ModalForm.php #101
Open
Update ModalForm.php #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error related to the "Esc" key has been fixed
dktapps
reviewed
Nov 5, 2023
| public function processData(&$data): void | ||
| { | ||
| if ($data === null) { | ||
| $data = null; |
There was a problem hiding this comment.
It prevents you from getting a nasty error in the console. I don't understand what makes sense. Can you give a more detailed answer?
There was a problem hiding this comment.
If this branch is entered, $data is already null, so this assignment is doing nothing useful.
There was a problem hiding this comment.
What is overlooked in this plugin is that you get an error when you press the escape key. When the data is empty, either yes or no must be selected, so I added something like this to prevent an error if the data is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error related to the "Esc" key has been fixed