Added option for maxReconnectInterval #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an extra option to specify the maximum amount of time to wait before attempting a reconnect. Defaults to -1, to keep the current behaviour.
|
Thanks. Rather than -1, I think a good sensible default will be something like 30000. Seems like more useful behavior and it makes it simpler for users to understand (no need to worry about magic numbers). Please include the description of this option in the header of the JS and README |
|
Great, will do. Also noticed that it may need to be documented in the .ts file as well? |
|
uhhh actually I forgot about the .ts file. Yeah, that needs to be updated too. In fact, some other recent changes have been left out from that file. I suggest doing that as a separate pull-request. If you have questions about the .ts stuff, ask @drewnoakes |
Now defaults to 30,000. Removed the -1 magic number. Added documentation on use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an extra option to specify the maximum amount of time to wait
before attempting a reconnect. Defaults to -1, to keep the current
behaviour.