Updated ts with new option #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an extra option to specify the maximum amount of time to wait before attempting a reconnect. Defaults to -1, to keep the current behaviour.
Now defaults to 30,000. Removed the -1 magic number. Added documentation on use.
| setTimeout(function() { | ||
| self.reconnectAttempts++; | ||
| connect(true); | ||
| }, self.reconnectInterval * Math.pow(self.reconnectDecay, self.reconnectAttempts)); | ||
| }, timeout > self.maxReconnectInterval ? self.maxReconnectInterval : timeout); |
There was a problem hiding this comment.
Simplify: Max.min(timeout, self.maxReconnectInterval)
|
Ended up simplifying this on the original pull request |
| @@ -23,6 +23,9 @@ declare class ReconnectingWebSocket | |||
| /** The number of milliseconds to delay before attempting to reconnect. */ | |||
| public reconnectInterval: number; | |||
|
|
|||
| /** The maximum number of milliseconds to delay a reconnection attempt. */ | |||
There was a problem hiding this comment.
Indentation does not match rest of file
|
Sorry... IDE didn't know what a .ts was and decided to use a tab rather than spaces, I didn't notice... |
|
Merged thanks (after I clicked the wrong button). All good now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added maxReconnectInterval to .ts file.
Bit new to git/github, so hope I've done the new branch/pull request correctly...