-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 전체 리뷰 조회 및 공개 여부 전환에 V2 API 적용 #475
Open
scarf005
wants to merge
5
commits into
develop
Choose a base branch
from
ts-rest
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
force-pushed
the
ts-rest
branch
4 times, most recently
from
July 8, 2023 06:06
b473b47
to
8c5cf87
Compare
scarf005
changed the title
feat: 리뷰 공개 여부를 ts-rest로 관리
feat: 전체 리뷰 조회 및 공개 여부 전환에 V2 API 적용
Aug 28, 2023
chanhihi
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아~ 완벽히 이해했어!
mink97
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 그런거구나 완벽히 이해했어.(설명 더 해주시면 좋겠습니다.)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
2023-08-28_09-43-18.mp4
@ts-rest/react-query
적용 #472@tanstack/react-query와 ts-rest를 사용해 전체 리뷰 조회와 리뷰 공개 여부 전환을 리팩터링한 예제입니다.
jiphyeonjeon-42/backend#705
변경점
usePatchReviewsId
훅에서useApi
를client.reviews.patch.useMutation
으로 전환했습니다.useGetReviews
훅을 react query를 사용하도록 바꾸었습니다.참고자료