Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GET 전체 reviews #705

Merged
merged 3 commits into from
Aug 31, 2023
Merged

feat: GET 전체 reviews #705

merged 3 commits into from
Aug 31, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Aug 28, 2023 •
edited
Loading

개요

작업 사항

  • 메타데이터 페이지네이션 함수
  • GET reviews
  • github releaeses 자동 배포 명령어

변경점

  • Visibility 타입을 'public' | 'private' | 'all' 에서 'public' | 'hidden' | 'all'으로 바꾸었습니다.
  • response meta 타입을 totalItems와 totalPages로 간략화했는데, 나머지 정보는 프론트엔드에서 이미 갖고 있기 때문입니다.

목적

@scarf005 scarf005 linked an issue Aug 28, 2023 that may be closed by this pull request
GET 전체 Reviews #699
Closed
@scarf005 scarf005 temporarily deployed to development August 28, 2023 00:57 — with GitHub Actions Inactive
@scarf005 scarf005 mentioned this pull request Aug 28, 2023
Open
JeongJiHwan
JeongJiHwan reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@JeongJiHwan JeongJiHwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공통에서 사용되는 metaSchema가 변경되면 다른 api에서의 구현도 모두 변경되야 하는건가요?

@scarf005
Copy link
Member Author

기존에 있던 다른 API 구현들을 변경하지 않아도 괜찮습니다.
typescript와 zod에서는 지정된 타입보다 추가로 있는 필드를 무시하는데, metaSchema의 경우에는 필드를 제거만 했기 때문입니다. (itemCount, itemsPerPage, currentPage)

JeongJiHwan
JeongJiHwan approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@JeongJiHwan JeongJiHwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~

@scarf005
Copy link
Member Author

정기회의에서도 필드 삭제에 대해 다룰게요

jimin52
jimin52 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@jimin52 jimin52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

@scarf005 scarf005 merged commit 3652cb1 into develop Aug 31, 2023
4 checks passed
@scarf005 scarf005 deleted the 699-get-전체-reviews branch August 31, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeongJiHwan JeongJiHwan JeongJiHwan approved these changes

@jimin52 jimin52 jimin52 approved these changes

@nyj001012 nyj001012 Awaiting requested review from nyj001012

Assignees
No one assigned
Labels
None yet
Projects
집현전 v2 리팩터링
Status: 완료
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET 전체 Reviews
3 participants
@scarf005 @jimin52 @JeongJiHwan