Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shoaib/issue#439 #465

Closed
wants to merge 3 commits into from
Closed

shoaib/issue#439 #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c827afe
Update JPF_java_lang_String.java
sshaikshoaib Jun 22, 2024
36333b3
shoaib1/issue#439
sshaikshoaib Jun 25, 2024
33bf7c2
shoaib2/issue#439
sshaikshoaib Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"java.debug.settings.onBuildFailureProceed": true
}
5 changes: 3 additions & 2 deletions src/peers/gov/nasa/jpf/vm/JPF_java_lang_String.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,11 @@ public boolean equals__Ljava_lang_Object_2__Z (MJIEnv env, int objRef, int argRe
if (argRef == MJIEnv.NULL) {
return false;
}

if (!env.isInstanceOf(argRef, "java.lang.String")) {
return false; // The object is not a String, so return false
}
String s1 = env.getStringObject(objRef);
String s2 = env.getStringObject(argRef);

return s1.equals(s2);
}

Expand Down
8 changes: 8 additions & 0 deletions src/tests/gov/nasa/jpf/test/java/lang/StringTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,14 @@ public void testEquals() {
assert !a.equals(c);
}
}

@Test
public void testEqualsWithNonStringObject() {
if (verifyNoPropertyViolation()) {
String a = "one two";
assert !a.equals(new Object());
}
}

@Test
public void testIndexOf() {
Expand Down
Loading