-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shoaib/issue#439 #465
shoaib/issue#439 #465
Conversation
i have changed .equals function to .compareTo function
Thank you for your implementation. Please also provide a unit test so we know that the new version of the code works as intended. See the wiki for instructions on how to write unit tests: https://github.com/javapathfinder/jpf-core/wiki/Writing-JPF-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a unit test, as this part of the code is currently not covered by a test, so we don't know if your change fixes the issue.
Hi @cyrille-artho I am a beginner and I have a good knowledge on java.so i used this knowledge to rectify the issue. |
i have added the test - public void testEqualsWithNonStringObject() - to verify my updated code
i have added the required tests for the updated code. please revies that and suggest me if any updates required |
Hi, |
i have added a check for objects in equals function
Thanks! This patch seems to fix the problem. To merge it, can you please remove the extra file |
Subsumed by #491 |
i have changed .equals function to .compareTo function. hope it works