-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read multiscale groups as datatrees #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or cosem-flavored array metadata
…right way to do it, but it's working.
This reverts commit fbfd4ab.
changes of note:
|
the core API changes are done, but the full extension of that API to formats like tif and .dat are either incomplete or untested, but that's acceptable and we can fix that later. going ahead with a merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the ability to use
read_xarray
on zarr / n5 groups to create an instance ofdatatree.DataTree
, provided all the arrays in that group can be resolved toxarray.DataArrays
.Additionally, this PR fixes an error in cosem-flavored metadata handling.
@tlambert03 Once it's done, I'm going to bring this new
read_xarray
functionality to bear on #42